[lib] populate community store on user login
Needs RevisionPublic
Actions

Authored by ginsu on Feb 26 2024, 1:02 AM.

Details

Reviewers

atul
inka
kamil

Summary

When a user logs in to the app we need to populate the community store with all the threads types that return true from threadTypeIsCommunityRoot

Linear task: https://linear.app/comm/issue/ENG-6159/introduce-community-reducer

Depends on D11191

Test Plan

Logged in and out and confirmed that the community store was being populated with the correct communities

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Feb 26 2024, 1:02 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 26 2024, 1:02 AM

ginsu edited the summary of this revision. (Show Details)Feb 26 2024, 1:03 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka, kamil.

ginsu added a parent revision: D11166: [lib] introduce community reducer.

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 26 2024, 1:12 AM

Harbormaster failed remote builds in B27156: Diff 37576!

will make sure ci passes before landing

Looks good

lib/reducers/community-reducer.js

43–58

You could do something like following:

const replaceOperations = Object.keys(newThreadInfos).reduce((acc, threadID) => {
  if (threadTypeIsCommunityRoot(newThreadInfos[threadID].type)) {
    const communityInfo = {
      enabledApps: defaultEnabledApps,
    };
    acc.push({
      type: 'replace_community',
      payload: {
        id: threadID,
        communityInfo,
      },
    });
  }
  return acc;
}, []);

(generated with ChatGPT)

that lets us avoid an iteration, but probably doesn't make a difference

This revision is now accepted and ready to land.Feb 26 2024, 2:19 PM

Harbormaster completed remote builds in B27156: Diff 37576.Feb 26 2024, 3:09 PM

kamil added inline comments.Feb 27 2024, 1:41 AM

lib/reducers/community-reducer.js
34–38	wondering, shouldn't we also add `action.type === fullStateSyncActionType`?

ginsu added inline comments.Feb 27 2024, 8:53 PM

lib/reducers/community-reducer.js
34–38	I spoke to @atul about this and from what I understood we don't need this type since the community store is not synced with the keyserver

ginsu edited the summary of this revision. (Show Details)Feb 27 2024, 11:37 PM

ginsu removed a parent revision: D11166: [lib] introduce community reducer.

ginsu edited the summary of this revision. (Show Details)Feb 28 2024, 12:21 AM

ginsu added a parent revision: D11191: DRAFT [lib/native/web] introduce migration to populate community store.

ginsu added a child revision: D11192: [lib] introduce removeCommunityActionType.Feb 28 2024, 12:26 AM

kamil added inline comments.Feb 28 2024, 12:56 AM

lib/reducers/community-reducer.js
34–38	But based on the code below, communities are computed based on `newThreadInfos` which are synced - see here (cc. @atul) I am afraid that on `fullStateSyncActionType` we will have inconsistency between threads (`threadTypeIsCommunityRoot`) and communities in this store