Differential D11166
[lib] introduce community reducer Authored by ginsu on Feb 26 2024, 12:01 AM. Tags None Referenced Files
Details
This diff introduces the barebones community reducer and all the necessary logic to get it integrated into our codebase. Subsequent diffs will handle extending the community reducer to handle other cases we need to cover in our business logic Linear task: https://linear.app/comm/issue/ENG-6159/introduce-community-reducer and https://linear.app/comm/issue/ENG-6535/start-processing-community-store-ops-on-sqllite Depends on D11165 Ran the following code + confirmed that a community was being added from this dispatched action const dispatch = useDispatch();
const fakeCommunityID = '256|84261';
const onPressAddCommunity = React.useCallback(() => {
const communityInfo: CommunityInfo = {
enabledApps: {
calendar: true,
wiki: false,
tasks: true,
files: true,
},
};
dispatch({
type: addCommunityActionType,
payload: {
id: fakeCommunityID,
newCommunityInfo: communityInfo,
},
});
}, [dispatch]);
Diff Detail
Event TimelineComment Actions Mostly looks good, but do we need to handle clearing the data on log out/delete account/etc? Comment Actions There is some ongoing work connected to clearing data right now, some context in ENG-6807, ENG-6424#comment-979868aa and this project link. In short, on log out/delete account/etc we delete DB anyway so it should be safe - and generating ops like remove_all interferes with the backup (we'll backup logs deleting everything so after restoration we'll have empty tables...). It might be good to get @tomek approval as he is working on Resilient user-specific state reset in March. One question to @ginsu: Comment Actions In our current approach, we don't need to do anything: resetUserSpecificState should handle it. Only the fields from nonUserSpecificFieldsWeb and nonUserSpecificFieldsNative survive these actions. But please test it. Comment Actions
This is a good call out, yes we will need a migration to handle initially populating the community store with all the threads that are community root. Here is a linear task to track that:
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||