Page MenuHomePhabricator
Differential D11160

[services] derive serialize/deserialize for WorkflowInProgress enum
ClosedPublic
Actions

Authored by varun on Feb 23 2024, 11:54 PM.
Tags
None
Referenced Files
F3400163: D11160.diff
Mon, Dec 2, 6:27 AM
Unknown Object (File)
Mon, Nov 11, 9:50 PM
Unknown Object (File)
Mon, Nov 11, 8:30 PM
Unknown Object (File)
Mon, Nov 11, 8:19 PM
Unknown Object (File)
Mon, Nov 11, 7:54 PM
Unknown Object (File)
Mon, Nov 11, 6:46 PM
Unknown Object (File)
Mon, Nov 11, 6:45 PM
Unknown Object (File)
Mon, Nov 11, 9:41 AM
View All 84 Files
Subscribers
ashoat
tomek

Details

Reviewers
will
michal
bartek
Commits
rCOMM9e266a65d4a0: [services] derive serialize/deserialize for WorkflowInProgress enum
Summary

we need to serialize/deserialize this enum so we can store it in and then retrieve and deserialize it from DynamoDB

Depends on D11150

Test Plan
  • call login start RPC, log the serialized and deserialized values
  • successfully log in
  • call register start RPC, log the serialized and deserialized values
  • successfully register
  • call update password start RPC, log the serialized and deserialized values
  • successfully change password

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Feb 23 2024, 11:54 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 23 2024, 11:54 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 24 2024, 12:05 AM
Harbormaster failed remote builds in B27136: Diff 37553!
varun updated this revision to Diff 37624.Feb 26 2024, 2:00 PM

add lock files

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 26 2024, 2:03 PM
Harbormaster failed remote builds in B27186: Diff 37624!
varun updated this revision to Diff 37869.Mar 5 2024, 9:00 PM

fix CI

Harbormaster completed remote builds in B27348: Diff 37869.Mar 5 2024, 9:16 PM
varun requested review of this revision.Mar 5 2024, 9:16 PM
varun updated this revision to Diff 37875.Mar 5 2024, 10:02 PM

fix serialization/deserialization of Login struct

Harbormaster completed remote builds in B27353: Diff 37875.Mar 5 2024, 10:21 PM
varun added a child revision: D11255: [identity] db client methods to interact with workflows table.Mar 5 2024, 10:55 PM
varun added a reviewer: bartek.Mar 5 2024, 11:24 PM
michal accepted this revision.Mar 6 2024, 4:10 AM
michal added inline comments.
services/identity/src/constants.rs
161

Duration::from_secs() is const so we could use it here, I find it clearer.

shared/grpc_clients/src/identity/device.rs
60–68

Can we use try_from for this?

This revision is now accepted and ready to land.Mar 6 2024, 4:10 AM
michal added inline comments.Mar 6 2024, 4:12 AM
services/identity/src/constants.rs
161

Ah, it's from chrono and not std but I think it still applies.

varun added inline comments.Mar 6 2024, 2:40 PM
services/identity/src/constants.rs
161

sure, i'll do the same for NONCE_TTL_DURATION as well

shared/grpc_clients/src/identity/device.rs
60–68

yeah good call

Closed by commit rCOMM9e266a65d4a0: [services] derive serialize/deserialize for WorkflowInProgress enum (authored by varun). · Explain WhyMar 6 2024, 3:02 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM9e266a65d4a0: [services] derive serialize/deserialize for WorkflowInProgress enum.

Revision Contents
Changeset List

PathSize
keyserver/
addons/
rust-node-addon/
native/
native_rust_library/
services/
blob/
commtest/
identity/
src/
11 lines
9 lines
tunnelbroker/
shared/
comm-lib/
comm-opaque2/
1 line
src/
server/
4 lines
grpc_clients/
1 line
src/
identity/
37 lines

Diff 37875

View Options

keyserver/addons/rust-node-addon/Cargo.lock

Loading...
View Options

native/native_rust_library/Cargo.lock

Loading...
View Options

services/blob/Cargo.lock

Loading...
View Options

services/commtest/Cargo.lock

Loading...
View Options

services/identity/Cargo.lock

Loading...
View Options

services/identity/src/client_service.rs

Loading...
View Options

services/identity/src/constants.rs

Loading...
View Options

services/tunnelbroker/Cargo.lock

Loading...
View Options

shared/comm-lib/Cargo.lock

Loading...
View Options

shared/comm-opaque2/Cargo.lock

Loading...
View Options

shared/comm-opaque2/Cargo.toml

Loading...
View Options

shared/comm-opaque2/src/server/login.rs

Loading...
View Options

shared/grpc_clients/Cargo.lock

Loading...
View Options

shared/grpc_clients/Cargo.toml

Loading...
View Options

shared/grpc_clients/src/identity/device.rs

Loading...