Paths

Table of Contentst

Differential D11160

[services] derive serialize/deserialize for WorkflowInProgress enum
ClosedPublic
Actions

Authored by varun on Feb 24 2024, 7:54 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

will
michal
bartek

Commits

rCOMM9e266a65d4a0: [services] derive serialize/deserialize for WorkflowInProgress enum

Summary

we need to serialize/deserialize this enum so we can store it in and then retrieve and deserialize it from DynamoDB

Depends on D11150

Test Plan

call login start RPC, log the serialized and deserialized values
successfully log in
call register start RPC, log the serialized and deserialized values
successfully register
call update password start RPC, log the serialized and deserialized values
successfully change password

Diff Detail

Repository

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Feb 24 2024, 7:54 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 24 2024, 7:54 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 24 2024, 8:05 AM

Harbormaster failed remote builds in B27136: Diff 37553!

add lock files

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 26 2024, 10:03 PM

Harbormaster failed remote builds in B27186: Diff 37624!

fix CI

Harbormaster completed remote builds in B27348: Diff 37869.Mar 6 2024, 5:16 AM

varun requested review of this revision.Mar 6 2024, 5:16 AM

fix serialization/deserialization of Login struct

Harbormaster completed remote builds in B27353: Diff 37875.Mar 6 2024, 6:21 AM

varun added a child revision: D11255: [identity] db client methods to interact with workflows table.Mar 6 2024, 6:55 AM

varun added a reviewer: bartek.Mar 6 2024, 7:24 AM

michal accepted this revision.Mar 6 2024, 12:10 PM

michal added inline comments.

services/identity/src/constants.rs
161 ↗	(On Diff #37875)	`Duration::from_secs()` is `const` so we could use it here, I find it clearer.
shared/grpc_clients/src/identity/device.rs
60–68 ↗	(On Diff #37875)	Can we use `try_from` for this?

This revision is now accepted and ready to land.Mar 6 2024, 12:10 PM

michal added inline comments.Mar 6 2024, 12:12 PM

services/identity/src/constants.rs
161 ↗	(On Diff #37875)	Ah, it's from `chrono` and not `std` but I think it still applies.

varun added inline comments.Mar 6 2024, 10:40 PM

services/identity/src/constants.rs
161 ↗	(On Diff #37875)	sure, i'll do the same for `NONCE_TTL_DURATION` as well
shared/grpc_clients/src/identity/device.rs
60–68 ↗	(On Diff #37875)	yeah good call

Closed by commit rCOMM9e266a65d4a0: [services] derive serialize/deserialize for WorkflowInProgress enum. · Explain WhyMar 6 2024, 11:02 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM9e266a65d4a0: [services] derive serialize/deserialize for WorkflowInProgress enum.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

client_service.rs

11 lines

9 lines

shared/

comm-opaque2/

1 line

src/

server/

4 lines

grpc_clients/

1 line

src/

identity/

37 lines

Diff 37553

services/identity/Cargo.lock

Loading...

services/identity/src/client_service.rs

Loading...

services/identity/src/constants.rs

Loading...

shared/comm-opaque2/Cargo.lock

Loading...

shared/comm-opaque2/Cargo.toml

Loading...

shared/comm-opaque2/src/server/login.rs

Loading...

shared/grpc_clients/Cargo.lock

Loading...

shared/grpc_clients/Cargo.toml

Loading...

shared/grpc_clients/src/identity/device.rs

Loading...