Create the store. By default, it should contain an empty array.
https://linear.app/comm/issue/ENG-7096/add-a-new-field-in-redux-where-ops-are-stored
Details
Details
Inspect Redux on web and native and check if the store is present. Also close and reopen the app to make sure that there are no inconsistencies.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
In the current design the flow should be like this:
- Receive message
- Decrypt
- Processing in redux and database
- Confirm
If we want to persist this, we could end up in a scenario where we open the app, and we have:
- Processing in redux and database
- Confirm
This requires implementing some additional things like remembering messageIDs, confirming not from the socket level but from the component responsible for processing etc.. With the current approach we will just start the flow again, it could be improved in the future but I think for now it might not be worth it.
| lib/types/db-ops-types.js | ||
|---|---|---|
| 6 ↗ | (On Diff #37895) | We need a mapping between actions and ops - https://linear.app/comm/issue/ENG-7094/introduce-a-mapping-between-actions-and-ops. The plan is for each action that we want to track, to introduce an ID which then can be used when an ops processing finishes. |
| 12 ↗ | (On Diff #37895) | If an action doesn't generate ops we can immediately report its completion to the caller. This array allows us to do that because we don't need to wait for other ops to complete. |
| lib/types/db-ops-types.js | ||
|---|---|---|
| 12 ↗ | (On Diff #37895) | it could be helpful to add comment in code explaining this |