Details

Reviewers

kamil
michal

Commits

rCOMM6bcc2eac04e6: [native] Broadcast device list update and send backup key stub

Summary

Primary device should broadcast the device list update to all peers. However, we don't have peer syncing yet, so as a stub, it only broadcasts it to all devices from its device list.
Also, stubbed message containing backup data key, which will be needed for backup restore on secondary device.

Depends on D11296

Test Plan

Added a few devices to the device list - made sure that after successful QR auth flow, all devices receive the device list update. Also, secondary device displays a console log with stub backup key.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Mar 11 2024, 6:49 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 11 2024, 6:49 AM

Harbormaster failed remote builds in B27440: Diff 37988!Mar 11 2024, 7:06 AM

bartek edited the summary of this revision. (Show Details)Mar 11 2024, 7:15 AM

bartek edited the test plan for this revision. (Show Details)

Rebase

Harbormaster failed remote builds in B27446: Diff 37994!Mar 11 2024, 7:35 AM

Rebase

Harbormaster failed remote builds in B27463: Diff 38012!Mar 12 2024, 12:21 AM

Commit missing changes

Harbormaster completed remote builds in B27467: Diff 38016.Mar 12 2024, 2:06 AM

bartek published this revision for review.Mar 12 2024, 2:20 AM

ashoat added inline comments.Mar 12 2024, 3:34 PM

native/profile/secondary-device-qr-code-scanner.react.js
62 ↗	(On Diff #38016)	Should we add an `invariant` here that `deviceLists.length > 0`?
native/qr-code/qr-code-screen.react.js
103 ↗	(On Diff #38016)	Is this `console.log` left over from debugging?

kamil requested changes to this revision.Mar 13 2024, 6:03 AM

kamil added inline comments.

lib/types/tunnelbroker/peer-to-peer-message-types.js
26 ↗	(On Diff #38016)	We should discuss whether this update should be sent encrypted via `olm` and create a task to add it in the future, then this also should be sent as subtype of `ENCRYPTED_MESSAGE`

This revision now requires changes to proceed.Mar 13 2024, 6:03 AM

bartek added a child revision: D11330: [lib][native] Extract QR code to a spearate component.Mar 14 2024, 10:37 AM

bartek mentioned this in D11331: [web] Add QR auth handler logic.Mar 14 2024, 10:39 AM

bartek added inline comments.Mar 18 2024, 5:21 AM

lib/types/tunnelbroker/peer-to-peer-message-types.js
26 ↗	(On Diff #38016)	Yes, good point, I was thinking about this too. I'm not sure if it's possible at this moment, so I created https://linear.app/comm/issue/ENG-7245/broadcast-device-list-updates-via-olm-sessions to address this
native/qr-code/qr-code-screen.react.js
103 ↗	(On Diff #38016)	It is replaced by actual backup restore call later in the stack