[web] factor out common code in authNewDeviceKeyUpload
ClosedPublic
Actions

Authored by varun on Mar 19 2024, 6:23 PM.

Tags

None

Referenced Files

	F1721747: D11362.diff
	Thu, May 9, 4:07 PM

	Unknown Object (File)
	Thu, Apr 25, 11:22 AM

	Unknown Object (File)
	Thu, Apr 25, 11:22 AM

	Unknown Object (File)
	Thu, Apr 25, 11:22 AM

	Unknown Object (File)
	Thu, Apr 25, 11:21 AM

	Unknown Object (File)
	Apr 6 2024, 12:08 AM

	Unknown Object (File)
	Apr 2 2024, 5:43 PM

	Unknown Object (File)
	Apr 1 2024, 4:34 AM

View All 12 Files

Subscribers

tomek

Details

Reviewers

ashoat
marcin
kamil

Commits

rCOMM40d04cc63042: [web] factor out common code in authNewDeviceKeyUpload

Summary

introduced helper functions that will be used in authExistingDeviceKeyUpload

Depends on D11361

Test Plan

ran flow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Mar 19 2024, 6:23 PM

Herald added a subscriber: tomek. · View Herald TranscriptMar 19 2024, 6:23 PM

varun added a child revision: D11363: [web] don't generate or send one time keys on login.Mar 19 2024, 6:27 PM

Harbormaster completed remote builds in B27619: Diff 38215.Mar 19 2024, 6:38 PM

varun requested review of this revision.Mar 19 2024, 6:38 PM

ashoat accepted this revision.Mar 20 2024, 11:06 AM

This revision is now accepted and ready to land.Mar 20 2024, 11:06 AM

Closed by commit rCOMM40d04cc63042: [web] factor out common code in authNewDeviceKeyUpload (authored by varun). · Explain WhyMar 25 2024, 12:52 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM40d04cc63042: [web] factor out common code in authNewDeviceKeyUpload.

Revision Contents
Changeset List

Path

Size

web/

grpc/

identity-service-client-wrapper.js

55 lines

Diff 38215

View Options

web/grpc/identity-service-client-wrapper.js

[web] factor out common code in authNewDeviceKeyUploadClosedPublicActions