Page MenuHomePhabricator
Differential D11438

[lib] Introduce bare minimum `messageTypes.UPDATE_RELATIONSHIP`
ClosedPublic
Actions

Authored by atul on Mar 28 2024, 7:40 AM.
Tags
None
Referenced Files
F1721549: D11438.diff
Thu, May 9, 1:16 PM
Unknown Object (File)
Wed, Apr 17, 2:16 PM
Unknown Object (File)
Wed, Apr 17, 2:16 PM
Unknown Object (File)
Wed, Apr 17, 4:41 AM
Unknown Object (File)
Wed, Apr 10, 5:09 PM
Unknown Object (File)
Wed, Apr 10, 3:05 PM
Unknown Object (File)
Apr 9 2024, 2:16 PM
Unknown Object (File)
Apr 6 2024, 11:41 PM
View All 15 Files
Subscribers
ashoat

Details

Reviewers
ginsu
varun
tomek
will
Commits
rCOMM27b1b15230d2: [lib] Introduce bare minimum `messageTypes.UPDATE_RELATIONSHIP`
Summary

Basically fill out update-relationships with contents of legacy-update-relationships with additional farcaster_mutual operation.

Based on following commit from hackathon branch: https://github.com/CommE2E/comm/commit/8dd3e3339b8ac1435bc79064c2a9253bb07334e8

Depends on D11436

Test Plan

flow/things work as expected in subsequent diffs

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Mar 28 2024, 7:40 AM
Herald added a subscriber: ashoat. · View Herald TranscriptMar 28 2024, 7:40 AM
Harbormaster completed remote builds in B27765: Diff 38445.Mar 28 2024, 7:55 AM
atul requested review of this revision.Mar 28 2024, 7:55 AM
atul added a child revision: D11439: [lib] Update union types in `message-types` to include `UpdateRelationship` types.Mar 28 2024, 8:00 AM
ginsu accepted this revision.Mar 28 2024, 8:24 PM

lgtm

This revision is now accepted and ready to land.Mar 28 2024, 8:24 PM
atul updated this revision to Diff 38749.Apr 3 2024, 3:07 PM

just rebase

Harbormaster failed remote builds in B27964: Diff 38749!Apr 3 2024, 3:10 PM
atul added a comment.Apr 4 2024, 11:51 AM

Rather than rebasing and updating stack, it should be fine to land as-is and make modifications in follow-up diffs since this message type is not yet available to prod clients.

Developers can delete any messageTypes.UPDATE_RELATIONSHIP messages they may create by filtering on type 22 from their dev DB.

atul updated this revision to Diff 38787.Apr 4 2024, 11:55 AM

land

Harbormaster completed remote builds in B27964: Diff 38749.Apr 4 2024, 12:00 PM
Harbormaster failed remote builds in B27985: Diff 38787!Apr 4 2024, 12:06 PM
This revision was landed with ongoing or failed builds.Apr 4 2024, 12:29 PM
Closed by commit rCOMM27b1b15230d2: [lib] Introduce bare minimum `messageTypes.UPDATE_RELATIONSHIP` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM27b1b15230d2: [lib] Introduce bare minimum `messageTypes.UPDATE_RELATIONSHIP`.

Revision Contents
Changeset List

PathSize
lib/
shared/
messages/
1 line
types/
4 lines
messages/
46 lines
6 lines

Diff 38445

View Options

lib/shared/messages/message-specs.js

Loading...
View Options

lib/types/message-types-enum.js

Loading...
View Options

lib/types/messages/update-relationship.js

Loading...
View Options

lib/types/validation.test.js

Loading...