[protos][identity] Add primary device keys to GetKeyserverKeys response
ClosedPublic
Actions

Authored by bartek on Mar 28 2024, 11:48 PM.

Details

Reviewers

will
ashoat
varun

Commits

rCOMM173f8128076f: [protos][identity] Add primary device keys to GetKeyserverKeys response

Summary

Addresses ENG-7161.

After discussions, we concluded that we need primary device public keys for social proof verification.
We can add it in a non-breaking manner to the existing RPC response.

Implemented function to fetch primary device data and added it to the RPC response.

Test Plan

Registered user on mobile
Set that user as a keyserver owner and registered the keyserver
Called the RPC - returned keyserver keys, primary device's identity keys and username

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Mar 28 2024, 11:48 PM

bartek held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptMar 28 2024, 11:48 PM

Harbormaster completed remote builds in B27815: Diff 38532.Mar 29 2024, 12:03 AM

Some comments/proposals appeared in ENG-7598 that we need to take into account here. Requesting review now to open discussions

Thanks for doing this! It makes sense to me. Agree with @varun's proposal in ENG-7598, and separately I think it would be good to address ENG-7532 soon to avoid breaking changes to this RPC (due to the use of Identity)

varun accepted this revision.Apr 1 2024, 8:42 PM

varun added inline comments.