Page MenuHomePhabricator
Differential D11505

[lib] introduce aux user types
ClosedPublic
Actions

Authored by will on Mar 31 2024, 9:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 28, 6:33 PM
Unknown Object (File)
Apr 16 2024, 1:38 PM
Unknown Object (File)
Apr 13 2024, 4:12 PM
Unknown Object (File)
Apr 10 2024, 5:20 AM
Unknown Object (File)
Apr 9 2024, 8:11 PM
Unknown Object (File)
Apr 9 2024, 8:11 PM
Unknown Object (File)
Apr 7 2024, 12:12 PM
Unknown Object (File)
Apr 5 2024, 8:30 PM
View All 11 Files
Subscribers
ashoat
tomek

Details

Reviewers
ginsu
kamil
atul
Commits
rCOMM32613d400084: [lib] introduce aux user types
Summary

This introduces the aux user types. Currently, only stores fids.

Test Plan

flow check

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Mar 31 2024, 9:35 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 31 2024, 9:35 PM
will added inline comments.Mar 31 2024, 9:38 PM
lib/types/aux-user-types.js
3 ↗(On Diff #38618)

There was discussion during the hackathon to formalize whether we were using fid or farcasterID. We currently use both in the codebase. Would it be better to write this as farcasterID?

will added a child revision: D11506: [lib] introduce the aux user store ops.Mar 31 2024, 9:41 PM
Harbormaster completed remote builds in B27885: Diff 38618.Mar 31 2024, 9:50 PM
will requested review of this revision.Mar 31 2024, 9:50 PM
ashoat added inline comments.Apr 1 2024, 9:00 AM
lib/types/aux-user-types.js
3 ↗(On Diff #38618)

That's a good question. I'm honestly okay either way, but agree it would be better to be consistent

atul accepted this revision.Apr 1 2024, 1:17 PM
atul added inline comments.
lib/types/aux-user-types.js
3 ↗(On Diff #38618)

Personally would prefer fid since I think it's clear in the context

This revision is now accepted and ready to land.Apr 1 2024, 1:17 PM
will added inline comments.Apr 4 2024, 8:15 AM
lib/types/aux-user-types.js
3 ↗(On Diff #38618)

Created a linear issue for this:

https://linear.app/comm/issue/ENG-7653/decide-on-farcasterid-or-fid

Closed by commit rCOMM32613d400084: [lib] introduce aux user types (authored by will). · Explain WhyApr 4 2024, 9:41 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM32613d400084: [lib] introduce aux user types.

Revision Contents
Changeset List

PathSize
lib/
types/
9 lines

Diff 38829

View Options

lib/types/aux-user-types.js

Loading...