Page MenuHomePhabricator

[lib] introduce aux user types
ClosedPublic

Authored by will on Mar 31 2024, 9:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 3, 1:50 AM
Unknown Object (File)
Oct 14 2024, 3:54 PM
Unknown Object (File)
Oct 14 2024, 3:54 PM
Unknown Object (File)
Oct 14 2024, 3:54 PM
Unknown Object (File)
Oct 14 2024, 3:54 PM
Unknown Object (File)
Sep 23 2024, 2:17 AM
Unknown Object (File)
Sep 14 2024, 8:47 PM
Unknown Object (File)
Sep 6 2024, 5:05 PM
Subscribers

Details

Summary

This introduces the aux user types. Currently, only stores fids.

Test Plan

flow check

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lib/types/aux-user-types.js
3 ↗(On Diff #38618)

There was discussion during the hackathon to formalize whether we were using fid or farcasterID. We currently use both in the codebase. Would it be better to write this as farcasterID?

will requested review of this revision.Mar 31 2024, 9:50 PM
lib/types/aux-user-types.js
3 ↗(On Diff #38618)

That's a good question. I'm honestly okay either way, but agree it would be better to be consistent

atul added inline comments.
lib/types/aux-user-types.js
3 ↗(On Diff #38618)

Personally would prefer fid since I think it's clear in the context

This revision is now accepted and ready to land.Apr 1 2024, 1:17 PM
lib/types/aux-user-types.js
3 ↗(On Diff #38618)
This revision was automatically updated to reflect the committed changes.