This implements the C++ SQLite operations for the aux user store
Depends on D11507
Details
Details
ran aux user queries test successfully
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
This looks correct, but would be great to have more thorough Test Plan. The aux-user-queries.tests are great though!
| native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h | ||
|---|---|---|
| 90–94 ↗ | (On Diff #38621) | Assuming this was all codegen'd so not reviewing |
| native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h | ||
| 103–106 ↗ | (On Diff #38621) | Assuming this was codegen'd so not reviewing |
| native/cpp/CommonCpp/DatabaseManagers/entities/AuxUserInfo.h | ||
| 23–24 ↗ | (On Diff #38621) | Let's add newline at end of file |
| native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h | ||
|---|---|---|
| 90–94 ↗ | (On Diff #38621) | These are actually not code generated. But tested these operations pretty thoroughly later in the stack so should be fine. |
| native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h | ||
| 103–106 ↗ | (On Diff #38621) | Same comment as above. This isn't code generated but tested later in the stack. |