This diff introduces the aux user store ops spec. This will be used to process aux user store operations.
Depends on D11505
Details
Details
- Reviewers
ginsu kamil atul - Commits
- rCOMM9f3470cecb74: [lib] introduce the aux user store ops
flow check. Functionality tested later in stack.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/ops/aux-user-store-ops.js | ||
|---|---|---|
| 12 ↗ | (On Diff #38619) | Same feedback as in other stack, I think we typically exclude the entity type in the operation.type and do eg replace, remove, remove_all, etc. |
| 46–52 ↗ | (On Diff #38619) | Can we define type outside so this is more readable. Also, wouldn't the following be equivalent: function convertAuxUserInfoToClientDBAuxUserInfo({
+id: string,
+auxUserInfo: AuxUserInfo,
}): ClientDBAuxUserInfo {and avoid need to define type altogether? |
| lib/ops/aux-user-store-ops.js | ||
|---|---|---|
| 46–52 ↗ | (On Diff #38619) | I don't think the second one counts as valid Flow syntax but I could be wrong |
| lib/ops/aux-user-store-ops.js | ||
|---|---|---|
| 46–52 ↗ | (On Diff #38619) | Looks like the Flow team is working on improving the duplication necessary if you use object destructuring (the reason Atul's syntax doesn't work, I think): https://medium.com/flow-type/announcing-component-syntax-b6c5285660d0 |