Page MenuHomePhabricator
Differential D11507

[sqlite] add aux users table for aux user store data
ClosedPublic
Actions

Authored by will on Mar 31 2024, 10:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 11 2024, 1:45 AM
Unknown Object (File)
Apr 10 2024, 9:59 PM
Unknown Object (File)
Apr 10 2024, 10:59 AM
Unknown Object (File)
Apr 8 2024, 3:42 PM
Unknown Object (File)
Apr 5 2024, 5:59 PM
F1451877: Screenshot 2024-04-01 at 1.09.42 AM.png
Mar 31 2024, 10:11 PM
Subscribers
ashoat
tomek

Details

Reviewers
ginsu
kamil
atul
Commits
rCOMMf8966e0ad79c: [sqlite] add aux users table for aux user store data
Summary

Creates the sqlite database table for aux user store

Depends on D11506

Test Plan

Tested on native and made sure aux user table was being initialized. Went through new schema flow by setting new simulator target

Screenshot 2024-04-01 at 1.09.42 AM.png (852×1 px, 220 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Mar 31 2024, 10:10 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 31 2024, 10:10 PM
will edited the summary of this revision. (Show Details)Mar 31 2024, 10:11 PM
will edited the test plan for this revision. (Show Details)
will added a parent revision: D11506: [lib] introduce the aux user store ops.
will added a child revision: D11508: [sqlite] introduce aux user store C++ methods.Mar 31 2024, 10:16 PM
Harbormaster completed remote builds in B27887: Diff 38620.Mar 31 2024, 10:26 PM
will requested review of this revision.Mar 31 2024, 10:26 PM
atul requested changes to this revision.Apr 1 2024, 1:37 PM

Can we update the test plan to include the create_schema scenario as well.

There have been a few times where the migrations work but creating new DB schema fails. It doesn't look like there are any issues, but would be good to have more thorough Test Plan for this.

This revision now requires changes to proceed.Apr 1 2024, 1:37 PM
atul accepted this revision.Apr 1 2024, 1:39 PM

Actually will accept, but please go through create_schema flow. Should be as easy as installing on new Simulator target

This revision is now accepted and ready to land.Apr 1 2024, 1:39 PM
will updated this revision to Diff 38746.Apr 3 2024, 12:38 PM

rebase

Harbormaster completed remote builds in B27962: Diff 38746.Apr 3 2024, 12:54 PM
will edited the test plan for this revision. (Show Details)Apr 4 2024, 9:20 PM
Closed by commit rCOMMf8966e0ad79c: [sqlite] add aux users table for aux user store data (authored by will). · Explain WhyApr 4 2024, 9:42 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMMf8966e0ad79c: [sqlite] add aux users table for aux user store data.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
17 lines
web/
shared-worker/
_generated/

Diff 38831

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Loading...