Page MenuHomePhabricator

[web] update session creation code to handle versioning
ClosedPublic

Authored by kamil on Apr 8 2024, 7:25 AM.
Tags
None
Referenced Files
F1806169: D11586.diff
Tue, May 21, 3:51 AM
Unknown Object (File)
Mon, May 20, 12:08 AM
Unknown Object (File)
Mon, May 20, 12:08 AM
Unknown Object (File)
Mon, May 20, 12:08 AM
Unknown Object (File)
Wed, May 8, 2:54 AM
Unknown Object (File)
Apr 21 2024, 3:40 AM
Unknown Object (File)
Apr 17 2024, 3:26 AM
Unknown Object (File)
Apr 17 2024, 12:22 AM
Subscribers

Details

Summary

This code:

  1. Updates contentInboundSessionCreator to decide whether to accept new or keep old session depending on sessionVersion
  2. Updates contentOutboundSessionCreator to return the session version (right now by default we override session and bump counter).
  3. Update Tunnelbroker message type to send sessionVersion along with init message

Depends on D11583

Test Plan
  1. Make sure session creation works
  2. Outbound session creation cause bumping counter
  3. Inbound session creation success or throw an appropriate error (tested all cases)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage