Page MenuHomePhabricator
Differential D11621

[native] fix copy in FarcasterPrompt
ClosedPublic
Actions

Authored by ginsu on Apr 10 2024, 9:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 19, 9:22 PM
Unknown Object (File)
Fri, Apr 18, 10:12 AM
Unknown Object (File)
Fri, Apr 18, 7:28 AM
Unknown Object (File)
Fri, Apr 18, 6:35 AM
Unknown Object (File)
Fri, Apr 18, 4:23 AM
Unknown Object (File)
Wed, Apr 16, 8:52 PM
Unknown Object (File)
Wed, Apr 16, 4:55 PM
Unknown Object (File)
Mar 9 2025, 6:37 AM
View All 76 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMMb6331ad353dd: [native] fix copy in FarcasterPrompt
Summary

In D11484 I accidentally removed the question mark in "Do you want to connect your Farcaster account?" This diff fixes that

Depends on D11613

Test Plan

Please see screenshot below

Screenshot 2024-04-10 at 12.44.25 PM.png (1×1 px, 770 KB)

Diff Detail

Repository
rCOMM Comm
Branch
eng-7498 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Apr 10 2024, 9:44 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 10 2024, 9:44 AM
ginsu edited the summary of this revision. (Show Details)Apr 10 2024, 9:45 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D11613: [lib/native] introduce connect farcaster alert handler.
ginsu attached a referenced file: F1510140: Screenshot 2024-04-10 at 12.44.25 PM.png. (Show Details)
ginsu mentioned this in D11484: [native] update FarcasterPrompt based on if the fid is set or not.
Harbormaster completed remote builds in B28126: Diff 38986.Apr 10 2024, 10:01 AM
ginsu requested review of this revision.Apr 10 2024, 10:01 AM
atul accepted this revision.Apr 10 2024, 10:03 AM
This revision is now accepted and ready to land.Apr 10 2024, 10:03 AM
ginsu updated this revision to Diff 39136.Apr 15 2024, 7:30 PM

rebase before landing

This revision was landed with ongoing or failed builds.Apr 15 2024, 7:32 PM
Closed by commit rCOMMb6331ad353dd: [native] fix copy in FarcasterPrompt (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMb6331ad353dd: [native] fix copy in FarcasterPrompt.
Harbormaster completed remote builds in B28232: Diff 39136.Apr 15 2024, 7:46 PM

Revision Contents
Changeset List

PathSize
native/
components/
2 lines

Diff 38986

View Options

native/components/farcaster-prompt.react.js

#pragma once #pragma once
#include <grpcpp/grpcpp.h> #include <grpcpp/grpcpp.h>
#include <mutex>
namespace comm { namespace comm {
namespace network { namespace network {
namespace reactor { namespace reactor {
enum class ReactorState { enum class ReactorState {
NONE = 0, NONE = 0,
RUNNING = 1, RUNNING = 1,
TERMINATED = 2, TERMINATED = 2,
DONE = 3, DONE = 3,
}; };
class BaseReactor { class BaseReactor {
private:
grpc::Status status = grpc::Status::OK;
std::mutex statusAccessMutex;
protected: protected:
ReactorState state = ReactorState::NONE; ReactorState state = ReactorState::NONE;
public: public:
grpc::Status getStatus() {
const std::unique_lock<std::mutex> lock(this->statusAccessMutex);
return this->status;
}
void setStatus(const grpc::Status &status) {
const std::unique_lock<std::mutex> lock(this->statusAccessMutex);
this->status = status;
}
ReactorState getState() const { ReactorState getState() const {
return this->state; return this->state;
} }
virtual void terminate(const grpc::Status &status){}; virtual void terminate(const grpc::Status &status){};
virtual void validate(){}; virtual void validate(){};
virtual void doneCallback(){}; virtual void doneCallback(){};
virtual void terminateCallback(){}; virtual void terminateCallback(){};
}; };
} // namespace reactor } // namespace reactor
} // namespace network } // namespace network
} // namespace comm } // namespace comm