[lib] Fix legacy register and SIWE
ClosedPublic
Actions

Authored by ashoat on Apr 16 2024, 11:29 AM.

Details

Reviewers

will
atul

Commits

rCOMM1dab1be1d2d4: [lib] Fix legacy register and SIWE

Summary

D11632 broke these by accidentally including a new parameter to the keyserver request, which fails input validation.

Test Plan

Test legacy register, legacy SIWE, and new registration flow (using legacy registration)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Apr 16 2024, 11:29 AM

Herald added a subscriber: tomek. · View Herald TranscriptApr 16 2024, 11:29 AM

ashoat published this revision for review.Apr 16 2024, 11:30 AM

atul accepted this revision.Apr 16 2024, 11:31 AM

This revision is now accepted and ready to land.Apr 16 2024, 11:31 AM

atul added inline comments.Apr 16 2024, 11:33 AM

lib/actions/siwe-actions.js
53 ↗	(On Diff #39156)	Might be a little clearer to reader if this was something like `siweAuthPayloadSansPreRequestUserInfo` since `rest` isn't super clear, but it's also right above so probably doesn't matter.

will accepted this revision.Apr 16 2024, 11:34 AM

This revision was landed with ongoing or failed builds.Apr 16 2024, 11:39 AM

Closed by commit rCOMM1dab1be1d2d4: [lib] Fix legacy register and SIWE (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM1dab1be1d2d4: [lib] Fix legacy register and SIWE.

Harbormaster completed remote builds in B28246: Diff 39156.Apr 16 2024, 11:47 AM

Revision Contents
Changeset List

Path

Size

lib/

actions/

siwe-actions.js

3 lines

user-actions.js

3 lines

Diff 39157

View Options

lib/actions/siwe-actions.js