Page MenuHomePhabricator
Differential D11686

[identity] Extract device list verification to separate func
ClosedPublic
Actions

Authored by bartek on Thu, Apr 18, 6:15 AM.
Tags
None
Referenced Files
F1777462: D11686.diff
Fri, May 17, 1:27 AM
Unknown Object (File)
Sun, May 12, 12:55 AM
Unknown Object (File)
Mon, May 6, 4:31 AM
Unknown Object (File)
Fri, May 3, 10:57 PM
Unknown Object (File)
Thu, May 2, 10:31 PM
Unknown Object (File)
Tue, Apr 30, 5:44 PM
Unknown Object (File)
Sat, Apr 27, 11:12 AM
Unknown Object (File)
Sat, Apr 27, 4:17 AM
View All 16 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
Commits
rCOMM1c6533aa4886: [identity] Extract device list verification to separate func
Summary

Some refactor - Extracted verification logic to the caller of apply_device_list_update() to give flexibility of giving different verification criteria for different scenarios (e.g. we want it to be able to replace device list with a singleton during backup restore, but not when primary device is adding a new device)

Depends on D11685

Test Plan
  • Manually called UpdateDeviceList RPC. Behaves the same before and after this diff
    • Valid device list (1 device added)
    • Invalid update (2 devices added)
    • Invalid update (no changes)
    • Invalid update (device removed)
  • Integration test still passes

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Thu, Apr 18, 6:15 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Apr 18, 6:15 AM
bartek added a child revision: D11687: [identity] Allow UpdateDeviceList RPC to remove devices.Thu, Apr 18, 6:16 AM
Harbormaster failed remote builds in B28292: Diff 39216!Thu, Apr 18, 6:38 AM
bartek updated this revision to Diff 39269.Fri, Apr 19, 2:33 AM

Rebase

Harbormaster completed remote builds in B28319: Diff 39269.Fri, Apr 19, 2:53 AM
bartek published this revision for review.Fri, Apr 19, 3:34 AM
bartek edited the summary of this revision. (Show Details)
bartek edited the test plan for this revision. (Show Details)
bartek added inline comments.
services/identity/src/grpc_services/authenticated.rs
430–431 ↗(On Diff #39269)

Actually this is done in the next diff

varun accepted this revision.Mon, Apr 22, 2:41 PM
This revision is now accepted and ready to land.Mon, Apr 22, 2:41 PM
Closed by commit rCOMM1c6533aa4886: [identity] Extract device list verification to separate func (authored by bartek). · Explain WhyThu, Apr 25, 12:37 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM1c6533aa4886: [identity] Extract device list verification to separate func.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
database/
18 lines
24 lines
grpc_services/
6 lines

Diff 39216

View Options

services/identity/src/database/device_list.rs

Loading...
View Options

services/identity/src/device_list.rs

Loading...
View Options

services/identity/src/grpc_services/authenticated.rs

Loading...