Page MenuHomePhabricator
Differential D11730

[lib/web/native] update `MessageID` in ops handling
ClosedPublic
Actions

Authored by kamil on Mon, Apr 22, 5:49 PM.
Tags
None
Referenced Files
F1779420: D11730.diff
Fri, May 17, 9:07 PM
Unknown Object (File)
Wed, May 15, 5:34 PM
Unknown Object (File)
Wed, May 15, 2:15 PM
Unknown Object (File)
Mon, May 13, 8:35 PM
Unknown Object (File)
Mon, May 13, 7:41 PM
Unknown Object (File)
Tue, May 7, 8:48 AM
Unknown Object (File)
Mon, May 6, 4:58 PM
Unknown Object (File)
Thu, May 2, 3:28 PM
View All 15 Files
Subscribers
ashoat

Details

Reviewers
tomek
Commits
rCOMM83bae84d1b8d: [lib/web/native] update `MessageID` in ops handling
Summary

We need to also be able to get sender's deviceID to send confirmation

Test Plan

FLow & tests

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Mon, Apr 22, 5:49 PM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptMon, Apr 22, 5:49 PM
kamil added a child revision: D11731: [lib/web/native] implement sending confirmation of processed message.Mon, Apr 22, 5:52 PM
kamil published this revision for review.Tue, Apr 23, 6:42 AM
ashoat added inline comments.Tue, Apr 23, 9:40 AM
lib/types/db-ops-types.js
5 ↗(On Diff #39381)

Let's rename this to something more specific. We already have MessageData in our JS codebase

tomek accepted this revision.Wed, Apr 24, 4:56 AM
tomek added inline comments.
lib/types/db-ops-types.js
6–7 ↗(On Diff #39381)
This revision is now accepted and ready to land.Wed, Apr 24, 4:56 AM
kamil updated this revision to Diff 39635.Mon, Apr 29, 2:44 AM
  • MessageData -> MessageSourceMetadata
  • make props read-only
Harbormaster completed remote builds in B28563: Diff 39635.Mon, Apr 29, 3:00 AM
Closed by commit rCOMM83bae84d1b8d: [lib/web/native] update `MessageID` in ops handling (authored by kamil). · Explain WhyMon, Apr 29, 4:01 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM83bae84d1b8d: [lib/web/native] update `MessageID` in ops handling.

Revision Contents
Changeset List

PathSize
lib/
hooks/
12 lines
reducers/
15 lines
12 lines
types/
7 lines
6 lines
4 lines
native/
redux/
4 lines
2 lines
web/
redux/
13 lines

Diff 39642

View Options

lib/hooks/ops-hooks.js

Loading...
View Options

lib/reducers/db-ops-reducer.js

Loading...
View Options

lib/reducers/db-ops-reducer.test.js

Loading...
View Options

lib/types/db-ops-types.js

Loading...
View Options

lib/types/redux-types.js

Loading...
View Options

lib/types/request-types.js

Loading...
View Options

native/redux/action-types.js

Loading...
View Options

native/redux/redux-setup.js

Loading...
View Options

web/redux/redux-setup.js

Loading...