Page MenuHomePhabricator
Differential D11739

[web] render `DBOpsHandler` in `TunnelbrokerProvider`
ClosedPublic
Actions

Authored by kamil on Tue, Apr 23, 5:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 7, 3:11 AM
Unknown Object (File)
Mon, May 6, 11:26 PM
Unknown Object (File)
Sat, May 4, 11:34 AM
Unknown Object (File)
Fri, May 3, 7:24 PM
Unknown Object (File)
Thu, May 2, 4:20 AM
Unknown Object (File)
Wed, May 1, 10:04 AM
Unknown Object (File)
Mon, Apr 29, 9:13 AM
Unknown Object (File)
Sun, Apr 28, 12:29 PM
View All 12 Files
Subscribers
ashoat

Details

Reviewers
tomek
bartek
Commits
rCOMM414c1f3ea27f: [web] render `DBOpsHandler` in `TunnelbrokerProvider`
Summary

We need to use Tunnelbroker to confirm message after successfully processing ops

Test Plan

Being able to call useTunnelbroker in DBOpsHandler and ops working properly on web

Diff Detail

Repository
rCOMM Comm
Branch
publish-receiver
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Tue, Apr 23, 5:17 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptTue, Apr 23, 5:17 AM
kamil added a child revision: D11731: [lib/web/native] implement sending confirmation of processed message.Tue, Apr 23, 5:18 AM
Harbormaster completed remote builds in B28402: Diff 39398.Tue, Apr 23, 5:34 AM
kamil published this revision for review.Tue, Apr 23, 6:42 AM
ashoat added inline comments.Tue, Apr 23, 9:41 AM
web/app.react.js
85

Can you undo this change?

tomek accepted this revision.Mon, Apr 29, 12:42 AM

Are there any actions that need ops processing dispatched before we render TunnelbrokerProvider?

This revision is now accepted and ready to land.Mon, Apr 29, 12:42 AM
kamil updated this revision to Diff 39649.Mon, Apr 29, 4:55 AM

undo change

Harbormaster completed remote builds in B28573: Diff 39649.Mon, Apr 29, 5:11 AM
kamil added a comment.Mon, Apr 29, 5:52 AM
In D11739#338949, @tomek wrote:

Are there any actions that need ops processing dispatched before we render TunnelbrokerProvider?

I don't think so, there isn't any gate or component that will cause DBOpsHandler not being rendered

Closed by commit rCOMM414c1f3ea27f: [web] render `DBOpsHandler` in `TunnelbrokerProvider` (authored by kamil). · Explain WhyMon, Apr 29, 6:04 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM414c1f3ea27f: [web] render `DBOpsHandler` in `TunnelbrokerProvider`.

Revision Contents
Changeset List

PathSize
web/
3 lines
2 lines

Diff 39398

View Options

web/app.react.js

Loading...
View Options

web/root.js

Loading...