[lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanCreateSidebarFromMessage`
ClosedPublic
Actions

Authored by atul on Apr 26 2024, 12:50 PM.

Details

Reviewers

ashoat
ginsu
tomek
varun

Commits

rCOMM50a37eef69e4: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in…

Summary

Similar to D11816, but for useCanCreateSidebarFromMessage

Depends on D11816

Test Plan

flow + close reading

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D11817 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Apr 26 2024, 12:50 PM

atul added a child revision: D11818: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanCreateReactionFromMessage`.

Harbormaster completed remote builds in B28540: Diff 39596.Apr 26 2024, 1:10 PM

atul requested review of this revision.Apr 26 2024, 1:10 PM

ashoat accepted this revision.Apr 27 2024, 6:42 PM

ashoat added inline comments.

lib/shared/thread-utils.js
1417 ↗	(On Diff #39596)
1428–1432 ↗	(On Diff #39596)

This revision is now accepted and ready to land.Apr 27 2024, 6:42 PM

land

Harbormaster failed remote builds in B28634: Diff 39751!May 2 2024, 11:02 AM

This revision was landed with ongoing or failed builds.May 2 2024, 11:03 AM

Closed by commit rCOMM50a37eef69e4: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM50a37eef69e4: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in….

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

19 lines

Diff 39751

View Options

lib/shared/thread-utils.js

[lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanCreateSidebarFromMessage`ClosedPublicActions