[lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanCreateReactionFromMessage`
ClosedPublic
Actions

Authored by atul on Apr 26 2024, 12:51 PM.

Details

Reviewers

ashoat
ginsu
tomek
varun

Commits

rCOMM4d4d115cf91c: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in…

Summary

Similar to D11817, but for useCanCreateReactionFromMessage.

Depends on D11817

Test Plan

flow + close reading

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D11818 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Apr 26 2024, 12:51 PM

atul added a child revision: D11819: [lib] Introduce `useCanToggleMessagePin` and consume in `native/Message`.Apr 26 2024, 12:55 PM

Harbormaster completed remote builds in B28541: Diff 39597.Apr 26 2024, 1:16 PM

atul requested review of this revision.Apr 26 2024, 1:16 PM

ashoat accepted this revision.Apr 27 2024, 6:43 PM

ashoat added inline comments.

lib/shared/reaction-utils.js
89 ↗	(On Diff #39597)
98–102 ↗	(On Diff #39597)

This revision is now accepted and ready to land.Apr 27 2024, 6:43 PM

addresss feedback

Harbormaster completed remote builds in B28642: Diff 39760.Fri, May 3, 12:18 PM

Closed by commit rCOMM4d4d115cf91c: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul). · Explain WhyFri, May 3, 12:47 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM4d4d115cf91c: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in….

Revision Contents
Changeset List

Path

Size

lib/

shared/

reaction-utils.js

22 lines

Diff 39760

View Options

lib/shared/reaction-utils.js

[lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanCreateReactionFromMessage`ClosedPublicActions