Page MenuHomePhabricator
Differential D11826

[identity] add span tracing to identity websocket server
ClosedPublic
Actions

Authored by will on Apr 28 2024, 10:59 PM.
Tags
None
Referenced Files
F6072427: D11826.id39605.diff
Sun, Apr 20, 1:52 PM
Unknown Object (File)
Sat, Apr 19, 12:25 PM
Unknown Object (File)
Fri, Apr 18, 7:57 PM
Unknown Object (File)
Thu, Apr 17, 11:03 PM
Unknown Object (File)
Wed, Apr 2, 3:25 PM
Unknown Object (File)
Mar 4 2025, 9:11 PM
Unknown Object (File)
Mar 4 2025, 9:11 PM
Unknown Object (File)
Mar 4 2025, 9:11 PM
View All 70 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMM9e76db7ca555: [identity] add span tracing to identity websocket server
Summary

Adds span tracing to identity service websocket server

Depends on D11825

Test Plan

cargo check and tested error on staging

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
services/
identity/
src/
websockets/
2 lines
6 lines
1 line

Diff 39943

View Options

services/identity/src/websockets/auth.rs

Show First 20 Lines • Show All 543 Lines • ▼ Show 20 Lines) => Promise<IdentityAuthResult> {
const client = React.useContext(IdentityClientContext); const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient; const identityClient = client?.identityClient;
invariant(identityClient, 'Identity client should be set'); invariant(identityClient, 'Identity client should be set');
if (!identityClient.registerPasswordUser) { if (!identityClient.registerPasswordUser) {
throw new Error('Register password user method unimplemented'); throw new Error('Register password user method unimplemented');
} }
return identityClient.registerPasswordUser; return identityClient.registerPasswordUser;
} }
function useIdentityPasswordRegisterReserved(): (
varunAuthorUnsubmitted
Done
Inline Actions

i'll separate these hooks from identityRegisterActionTypes a little, because they're not actually intended to be dispatched with those action types

varun: i'll separate these hooks from `identityRegisterActionTypes` a little, because they're not…
usename: string,
password: string,
keyserverMessage: string,
keyserverSignature: string,
) => Promise<IdentityAuthResult> {
const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient;
invariant(identityClient, 'Identity client should be set');
if (!identityClient.registerReservedPasswordUser) {
throw new Error('Register password user method unimplemented');
}
return identityClient.registerReservedPasswordUser;
}
function useIdentityWalletRegister(): ( function useIdentityWalletRegister(): (
walletAddress: string, walletAddress: string,
siweMessage: string, siweMessage: string,
siweSignature: string, siweSignature: string,
fid: ?string, fid: ?string,
) => Promise<IdentityAuthResult> { ) => Promise<IdentityAuthResult> {
const client = React.useContext(IdentityClientContext); const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient; const identityClient = client?.identityClient;
invariant(identityClient, 'Identity client should be set'); invariant(identityClient, 'Identity client should be set');
if (!identityClient.registerWalletUser) { if (!identityClient.registerWalletUser) {
throw new Error('Register wallet user method unimplemented'); throw new Error('Register wallet user method unimplemented');
} }
return identityClient.registerWalletUser; return identityClient.registerWalletUser;
} }
function useIdentityWalletRegisterReserved(): (
walletAddress: string,
siweMessage: string,
siweSignature: string,
keyserverMessage: string,
keyserverSignature: string,
) => Promise<IdentityAuthResult> {
const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient;
invariant(identityClient, 'Identity client should be set');
if (!identityClient.registerReservedWalletUser) {
throw new Error('Register wallet user method unimplemented');
}
return identityClient.registerReservedWalletUser;
}
const identityGenerateNonceActionTypes = Object.freeze({ const identityGenerateNonceActionTypes = Object.freeze({
started: 'IDENTITY_GENERATE_NONCE_STARTED', started: 'IDENTITY_GENERATE_NONCE_STARTED',
success: 'IDENTITY_GENERATE_NONCE_SUCCESS', success: 'IDENTITY_GENERATE_NONCE_SUCCESS',
failed: 'IDENTITY_GENERATE_NONCE_FAILED', failed: 'IDENTITY_GENERATE_NONCE_FAILED',
}); });
function useIdentityGenerateNonce(): () => Promise<string> { function useIdentityGenerateNonce(): () => Promise<string> {
const client = React.useContext(IdentityClientContext); const client = React.useContext(IdentityClientContext);
▲ Show 20 Lines • Show All 401 Lines • ▼ Show 20 Linesexport {
updateUserAvatar, updateUserAvatar,
deleteAccountActionTypes, deleteAccountActionTypes,
useDeleteAccount, useDeleteAccount,
useDeleteDiscardedIdentityAccount, useDeleteDiscardedIdentityAccount,
keyserverAuthActionTypes, keyserverAuthActionTypes,
keyserverAuth as keyserverAuthRawAction, keyserverAuth as keyserverAuthRawAction,
identityRegisterActionTypes, identityRegisterActionTypes,
useIdentityPasswordRegister, useIdentityPasswordRegister,
useIdentityPasswordRegisterReserved,
useIdentityWalletRegister, useIdentityWalletRegister,
useIdentityWalletRegisterReserved,
varunAuthorUnsubmitted
Done
Inline Actions

we actually don't need to expose these new hooks publicly, since they'll only be called by the identity login hooks

varun: we actually don't need to expose these new hooks publicly, since they'll only be called by the…
identityGenerateNonceActionTypes, identityGenerateNonceActionTypes,
useIdentityGenerateNonce, useIdentityGenerateNonce,
}; };
View Options

services/identity/src/websockets/mod.rs

Show First 20 Lines • Show All 543 Lines • ▼ Show 20 Lines) => Promise<IdentityAuthResult> {
const client = React.useContext(IdentityClientContext); const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient; const identityClient = client?.identityClient;
invariant(identityClient, 'Identity client should be set'); invariant(identityClient, 'Identity client should be set');
if (!identityClient.registerPasswordUser) { if (!identityClient.registerPasswordUser) {
throw new Error('Register password user method unimplemented'); throw new Error('Register password user method unimplemented');
} }
return identityClient.registerPasswordUser; return identityClient.registerPasswordUser;
} }
function useIdentityPasswordRegisterReserved(): (
varunAuthorUnsubmitted
Done
Inline Actions

i'll separate these hooks from identityRegisterActionTypes a little, because they're not actually intended to be dispatched with those action types

varun: i'll separate these hooks from `identityRegisterActionTypes` a little, because they're not…
usename: string,
password: string,
keyserverMessage: string,
keyserverSignature: string,
) => Promise<IdentityAuthResult> {
const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient;
invariant(identityClient, 'Identity client should be set');
if (!identityClient.registerReservedPasswordUser) {
throw new Error('Register password user method unimplemented');
}
return identityClient.registerReservedPasswordUser;
}
function useIdentityWalletRegister(): ( function useIdentityWalletRegister(): (
walletAddress: string, walletAddress: string,
siweMessage: string, siweMessage: string,
siweSignature: string, siweSignature: string,
fid: ?string, fid: ?string,
) => Promise<IdentityAuthResult> { ) => Promise<IdentityAuthResult> {
const client = React.useContext(IdentityClientContext); const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient; const identityClient = client?.identityClient;
invariant(identityClient, 'Identity client should be set'); invariant(identityClient, 'Identity client should be set');
if (!identityClient.registerWalletUser) { if (!identityClient.registerWalletUser) {
throw new Error('Register wallet user method unimplemented'); throw new Error('Register wallet user method unimplemented');
} }
return identityClient.registerWalletUser; return identityClient.registerWalletUser;
} }
function useIdentityWalletRegisterReserved(): (
walletAddress: string,
siweMessage: string,
siweSignature: string,
keyserverMessage: string,
keyserverSignature: string,
) => Promise<IdentityAuthResult> {
const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient;
invariant(identityClient, 'Identity client should be set');
if (!identityClient.registerReservedWalletUser) {
throw new Error('Register wallet user method unimplemented');
}
return identityClient.registerReservedWalletUser;
}
const identityGenerateNonceActionTypes = Object.freeze({ const identityGenerateNonceActionTypes = Object.freeze({
started: 'IDENTITY_GENERATE_NONCE_STARTED', started: 'IDENTITY_GENERATE_NONCE_STARTED',
success: 'IDENTITY_GENERATE_NONCE_SUCCESS', success: 'IDENTITY_GENERATE_NONCE_SUCCESS',
failed: 'IDENTITY_GENERATE_NONCE_FAILED', failed: 'IDENTITY_GENERATE_NONCE_FAILED',
}); });
function useIdentityGenerateNonce(): () => Promise<string> { function useIdentityGenerateNonce(): () => Promise<string> {
const client = React.useContext(IdentityClientContext); const client = React.useContext(IdentityClientContext);
▲ Show 20 Lines • Show All 401 Lines • ▼ Show 20 Linesexport {
updateUserAvatar, updateUserAvatar,
deleteAccountActionTypes, deleteAccountActionTypes,
useDeleteAccount, useDeleteAccount,
useDeleteDiscardedIdentityAccount, useDeleteDiscardedIdentityAccount,
keyserverAuthActionTypes, keyserverAuthActionTypes,
keyserverAuth as keyserverAuthRawAction, keyserverAuth as keyserverAuthRawAction,
identityRegisterActionTypes, identityRegisterActionTypes,
useIdentityPasswordRegister, useIdentityPasswordRegister,
useIdentityPasswordRegisterReserved,
useIdentityWalletRegister, useIdentityWalletRegister,
useIdentityWalletRegisterReserved,
varunAuthorUnsubmitted
Done
Inline Actions

we actually don't need to expose these new hooks publicly, since they'll only be called by the identity login hooks

varun: we actually don't need to expose these new hooks publicly, since they'll only be called by the…
identityGenerateNonceActionTypes, identityGenerateNonceActionTypes,
useIdentityGenerateNonce, useIdentityGenerateNonce,
}; };
View Options

services/identity/src/websockets/send.rs

Show First 20 Lines • Show All 543 Lines • ▼ Show 20 Lines) => Promise<IdentityAuthResult> {
const client = React.useContext(IdentityClientContext); const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient; const identityClient = client?.identityClient;
invariant(identityClient, 'Identity client should be set'); invariant(identityClient, 'Identity client should be set');
if (!identityClient.registerPasswordUser) { if (!identityClient.registerPasswordUser) {
throw new Error('Register password user method unimplemented'); throw new Error('Register password user method unimplemented');
} }
return identityClient.registerPasswordUser; return identityClient.registerPasswordUser;
} }
function useIdentityPasswordRegisterReserved(): (
varunAuthorUnsubmitted
Done
Inline Actions

i'll separate these hooks from identityRegisterActionTypes a little, because they're not actually intended to be dispatched with those action types

varun: i'll separate these hooks from `identityRegisterActionTypes` a little, because they're not…
usename: string,
password: string,
keyserverMessage: string,
keyserverSignature: string,
) => Promise<IdentityAuthResult> {
const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient;
invariant(identityClient, 'Identity client should be set');
if (!identityClient.registerReservedPasswordUser) {
throw new Error('Register password user method unimplemented');
}
return identityClient.registerReservedPasswordUser;
}
function useIdentityWalletRegister(): ( function useIdentityWalletRegister(): (
walletAddress: string, walletAddress: string,
siweMessage: string, siweMessage: string,
siweSignature: string, siweSignature: string,
fid: ?string, fid: ?string,
) => Promise<IdentityAuthResult> { ) => Promise<IdentityAuthResult> {
const client = React.useContext(IdentityClientContext); const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient; const identityClient = client?.identityClient;
invariant(identityClient, 'Identity client should be set'); invariant(identityClient, 'Identity client should be set');
if (!identityClient.registerWalletUser) { if (!identityClient.registerWalletUser) {
throw new Error('Register wallet user method unimplemented'); throw new Error('Register wallet user method unimplemented');
} }
return identityClient.registerWalletUser; return identityClient.registerWalletUser;
} }
function useIdentityWalletRegisterReserved(): (
walletAddress: string,
siweMessage: string,
siweSignature: string,
keyserverMessage: string,
keyserverSignature: string,
) => Promise<IdentityAuthResult> {
const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient;
invariant(identityClient, 'Identity client should be set');
if (!identityClient.registerReservedWalletUser) {
throw new Error('Register wallet user method unimplemented');
}
return identityClient.registerReservedWalletUser;
}
const identityGenerateNonceActionTypes = Object.freeze({ const identityGenerateNonceActionTypes = Object.freeze({
started: 'IDENTITY_GENERATE_NONCE_STARTED', started: 'IDENTITY_GENERATE_NONCE_STARTED',
success: 'IDENTITY_GENERATE_NONCE_SUCCESS', success: 'IDENTITY_GENERATE_NONCE_SUCCESS',
failed: 'IDENTITY_GENERATE_NONCE_FAILED', failed: 'IDENTITY_GENERATE_NONCE_FAILED',
}); });
function useIdentityGenerateNonce(): () => Promise<string> { function useIdentityGenerateNonce(): () => Promise<string> {
const client = React.useContext(IdentityClientContext); const client = React.useContext(IdentityClientContext);
▲ Show 20 Lines • Show All 401 Lines • ▼ Show 20 Linesexport {
updateUserAvatar, updateUserAvatar,
deleteAccountActionTypes, deleteAccountActionTypes,
useDeleteAccount, useDeleteAccount,
useDeleteDiscardedIdentityAccount, useDeleteDiscardedIdentityAccount,
keyserverAuthActionTypes, keyserverAuthActionTypes,
keyserverAuth as keyserverAuthRawAction, keyserverAuth as keyserverAuthRawAction,
identityRegisterActionTypes, identityRegisterActionTypes,
useIdentityPasswordRegister, useIdentityPasswordRegister,
useIdentityPasswordRegisterReserved,
useIdentityWalletRegister, useIdentityWalletRegister,
useIdentityWalletRegisterReserved,
varunAuthorUnsubmitted
Done
Inline Actions

we actually don't need to expose these new hooks publicly, since they'll only be called by the identity login hooks

varun: we actually don't need to expose these new hooks publicly, since they'll only be called by the…
identityGenerateNonceActionTypes, identityGenerateNonceActionTypes,
useIdentityGenerateNonce, useIdentityGenerateNonce,
}; };