Page MenuHomePhabricator
Differential D11825

[identity] Add span tracing to grpc handlers
ClosedPublic
Actions

Authored by will on Apr 28 2024, 10:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 19, 7:26 AM
Unknown Object (File)
Sat, Apr 19, 7:20 AM
Unknown Object (File)
Sat, Apr 19, 12:04 AM
Unknown Object (File)
Fri, Apr 18, 2:13 PM
Unknown Object (File)
Tue, Apr 1, 1:25 AM
Unknown Object (File)
Mar 4 2025, 9:11 PM
Unknown Object (File)
Mar 4 2025, 9:11 PM
Unknown Object (File)
Mar 4 2025, 9:11 PM
View All 70 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMM40c5c2d8756c: [identity] Add span tracing to grpc handlers
Summary

Adds span tracing to the grpc handlers through the instrument attribute

Should hopefully give us more information to diagnose errors like https://linear.app/comm/issue/ENG-7866/getkeyserverkeys-error-on-staging-identity-unexpected-error#comment-94f5f650

Depends on D11824

Test Plan

cargo check

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
services/
identity/
src/
18 lines
grpc_services/
17 lines

Diff 39942

View Options

services/identity/src/client_service.rs

  • This file was added.
// @flow
import reduceKeyserverStore from './keyserver-reducer.js';
import { deleteKeyserverAccountActionTypes } from '../actions/user-actions.js';
import { defaultKeyserverInfo } from '../types/keyserver-types.js';
describe('reduceKeyserverStore', () => {
it('removes from the store keyservers the user has disconnected from', () => {
const oldKeyserverStore = {
keyserverInfos: {
['0']: defaultKeyserverInfo('url1'),
['100']: defaultKeyserverInfo('url2'),
['200']: defaultKeyserverInfo('url3'),
},
};
const deleteAccountAction = {
type: deleteKeyserverAccountActionTypes.success,
payload: {
currentUserInfo: { anonymous: true },
preRequestUserState: {
cookiesAndSessions: {},
currentUserInfo: {
id: '1000',
username: 'test',
},
},
keyserverIDs: ['100', '200'],
},
loadingInfo: {
fetchIndex: 1,
trackMultipleRequests: false,
customKeyName: undefined,
},
};
expect(
reduceKeyserverStore(oldKeyserverStore, deleteAccountAction),
).toEqual({ keyserverInfos: { ['0']: defaultKeyserverInfo('url1') } });
});
});
View Options

services/identity/src/grpc_services/authenticated.rs

  • This file was added.
// @flow
import reduceKeyserverStore from './keyserver-reducer.js';
import { deleteKeyserverAccountActionTypes } from '../actions/user-actions.js';
import { defaultKeyserverInfo } from '../types/keyserver-types.js';
describe('reduceKeyserverStore', () => {
it('removes from the store keyservers the user has disconnected from', () => {
const oldKeyserverStore = {
keyserverInfos: {
['0']: defaultKeyserverInfo('url1'),
['100']: defaultKeyserverInfo('url2'),
['200']: defaultKeyserverInfo('url3'),
},
};
const deleteAccountAction = {
type: deleteKeyserverAccountActionTypes.success,
payload: {
currentUserInfo: { anonymous: true },
preRequestUserState: {
cookiesAndSessions: {},
currentUserInfo: {
id: '1000',
username: 'test',
},
},
keyserverIDs: ['100', '200'],
},
loadingInfo: {
fetchIndex: 1,
trackMultipleRequests: false,
customKeyName: undefined,
},
};
expect(
reduceKeyserverStore(oldKeyserverStore, deleteAccountAction),
).toEqual({ keyserverInfos: { ['0']: defaultKeyserverInfo('url1') } });
});
});