[identity] Add span tracing to grpc handlers
ClosedPublic
Actions

Authored by will on Apr 28 2024, 10:58 PM.

Details

Reviewers

varun
bartek

Commits

rCOMM40c5c2d8756c: [identity] Add span tracing to grpc handlers

Summary

Adds span tracing to the grpc handlers through the instrument attribute

Should hopefully give us more information to diagnose errors like https://linear.app/comm/issue/ENG-7866/getkeyserverkeys-error-on-staging-identity-unexpected-error#comment-94f5f650

Depends on D11824

Test Plan

cargo check

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

will created this revision.Apr 28 2024, 10:58 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 28 2024, 10:58 PM

will added a child revision: D11826: [identity] add span tracing to identity websocket server.Apr 28 2024, 10:59 PM

Harbormaster completed remote builds in B28548: Diff 39604.Apr 28 2024, 11:13 PM

will requested review of this revision.Apr 28 2024, 11:13 PM

will edited the summary of this revision. (Show Details)Apr 28 2024, 11:21 PM

varun accepted this revision.Apr 29 2024, 10:42 AM

This revision is now accepted and ready to land.Apr 29 2024, 10:42 AM

bartek accepted this revision.May 5 2024, 10:36 PM

Closed by commit rCOMM40c5c2d8756c: [identity] Add span tracing to grpc handlers (authored by will). · Explain WhyMay 8 2024, 10:33 AM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM40c5c2d8756c: [identity] Add span tracing to grpc handlers.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

client_service.rs

18 lines

grpc_services/

authenticated.rs

17 lines

Diff 39942

View Options

services/identity/src/client_service.rs