Page MenuHomePhabricator
Differential D11853

[terraform] metric filters for error logs in identity service
ClosedPublic
Actions

Authored by will on Wed, May 1, 8:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 15, 7:44 PM
Unknown Object (File)
Wed, May 15, 10:08 AM
Unknown Object (File)
Mon, May 13, 9:00 PM
Unknown Object (File)
Mon, May 13, 3:45 PM
Unknown Object (File)
Mon, May 13, 4:58 AM
Unknown Object (File)
Tue, May 7, 9:01 PM
Unknown Object (File)
Tue, May 7, 9:00 PM
Unknown Object (File)
Tue, May 7, 10:07 AM
View All 10 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMMa416e996d6d6: [terraform] metric filters for error logs in identity service
Summary

This introduces metric filters to be used by cloudwatch alarms later in the stack.

Decided to use a for_each pattern so adding new identity alarms can be as easy as adding the pattern to identity_error_patterns.

Depends on D11852

Test Plan

Activated metric filter successfully with example error logs on AWS Console

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Wed, May 1, 8:07 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptWed, May 1, 8:07 PM
will edited the summary of this revision. (Show Details)Wed, May 1, 8:10 PM
will added a parent revision: D11852: [identity] Add prefixes to error logs for filtering.
will added a child revision: D11854: [terraform] identity service cloudwatch alarms.
Harbormaster completed remote builds in B28619: Diff 39726.Wed, May 1, 8:22 PM
will requested review of this revision.Wed, May 1, 8:22 PM
varun accepted this revision.Thu, May 2, 11:35 AM
varun mentioned this in D11854: [terraform] identity service cloudwatch alarms.
varun added 1 blocking reviewer(s): bartek.
varun added inline comments.
services/terraform/remote/aws_cloudwatch_alarms.tf
6 ↗(On Diff #39726)

see inline comment on D11854

bartek accepted this revision.Sun, May 5, 10:49 PM
bartek added inline comments.
services/terraform/remote/aws_cloudwatch_alarms.tf
42 ↗(On Diff #39726)

Nice!

45 ↗(On Diff #39726)

So, following discussion from D11852, the $.fields.message could be simply replaced with $.fields.errorType?

This revision is now accepted and ready to land.Sun, May 5, 10:49 PM
will added inline comments.Mon, May 6, 9:28 AM
services/terraform/remote/aws_cloudwatch_alarms.tf
45 ↗(On Diff #39726)

Yep! That would be correct.

will updated this revision to Diff 39875.EditedMon, May 6, 2:16 PM

add sync pattern and address review feedback

Harbormaster completed remote builds in B28721: Diff 39875.Mon, May 6, 2:35 PM
Closed by commit rCOMMa416e996d6d6: [terraform] metric filters for error logs in identity service (authored by will). · Explain WhyWed, May 8, 10:33 AM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMMa416e996d6d6: [terraform] metric filters for error logs in identity service.

Revision Contents
Changeset List

PathSize
services/
terraform/
remote/
23 lines

Diff 39950

View Options

services/terraform/remote/aws_cloudwatch_alarms.tf

Loading...