Page MenuHomePhabricator
Differential D11828

[identity] add span tracing to identity device_list.rs functions
ClosedPublic
Actions

Authored by will on Apr 28 2024, 11:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 5, 7:24 PM
Unknown Object (File)
Mar 4 2025, 9:11 PM
Unknown Object (File)
Mar 4 2025, 9:11 PM
Unknown Object (File)
Mar 4 2025, 9:11 PM
Unknown Object (File)
Mar 4 2025, 9:11 PM
Unknown Object (File)
Jan 22 2025, 11:51 PM
Unknown Object (File)
Jan 19 2025, 10:44 AM
Unknown Object (File)
Jan 8 2025, 10:05 PM
View All 63 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMM872a76c9132d: [identity] add span tracing to identity device_list.rs functions
Summary

This adds span tracing to identity service device_list.rs functions

Depends on D11827

Test Plan

cargo check

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
services/
identity/
src/
database/
16 lines

Diff 39945

View Options

services/identity/src/database/device_list.rs

Show All 30 Lines
use super::DatabaseClient; use super::DatabaseClient;
impl DatabaseClient { impl DatabaseClient {
/// Gets the next one-time key for the account and then, in a transaction, /// Gets the next one-time key for the account and then, in a transaction,
/// deletes the key and updates the key count /// deletes the key and updates the key count
/// ///
/// Returns the retrieved one-time key if it exists and a boolean indicating /// Returns the retrieved one-time key if it exists and a boolean indicating
/// whether the `spawn_refresh_keys_task`` was called /// whether the `spawn_refresh_keys_task`` was called
#[tracing::instrument(skip_all)]
pub(super) async fn get_one_time_key( pub(super) async fn get_one_time_key(
&self, &self,
user_id: &str, user_id: &str,
device_id: &str, device_id: &str,
account_type: OlmAccountType, account_type: OlmAccountType,
can_request_more_keys: bool, can_request_more_keys: bool,
) -> Result<(Option<String>, bool), Error> { ) -> Result<(Option<String>, bool), Error> {
use crate::constants::devices_table; use crate::constants::devices_table;
▲ Show 20 Lines • Show All 102 Lines • ▼ Show 20 Lines loop {
); );
return Err(Error::AwsSdk(dynamo_db_error)); return Err(Error::AwsSdk(dynamo_db_error));
} }
} }
} }
} }
} }
#[tracing::instrument(skip_all)]
async fn get_one_time_keys( async fn get_one_time_keys(
&self, &self,
user_id: &str, user_id: &str,
device_id: &str, device_id: &str,
account_type: OlmAccountType, account_type: OlmAccountType,
num_keys: Option<usize>, num_keys: Option<usize>,
) -> Result<Vec<OTKRow>, Error> { ) -> Result<Vec<OTKRow>, Error> {
use crate::constants::one_time_keys_table::*; use crate::constants::one_time_keys_table::*;
Show All 33 Lines if let Some(limit) = num_keys {
error!("There are fewer one-time keys than the number requested"); error!("There are fewer one-time keys than the number requested");
return Err(Error::NotEnoughOneTimeKeys); return Err(Error::NotEnoughOneTimeKeys);
} }
} }
Ok(otk_rows) Ok(otk_rows)
} }
#[tracing::instrument(skip_all)]
pub async fn append_one_time_prekeys( pub async fn append_one_time_prekeys(
&self, &self,
user_id: &str, user_id: &str,
device_id: &str, device_id: &str,
content_one_time_keys: &Vec<String>, content_one_time_keys: &Vec<String>,
notif_one_time_keys: &Vec<String>, notif_one_time_keys: &Vec<String>,
) -> Result<(), Error> { ) -> Result<(), Error> {
use crate::constants::retry; use crate::constants::retry;
▲ Show 20 Lines • Show All 115 Lines • ▼ Show 20 Lines loop {
} }
} }
} }
} }
Ok(()) Ok(())
} }
#[tracing::instrument(skip_all)]
async fn get_otk_count( async fn get_otk_count(
&self, &self,
user_id: &str, user_id: &str,
device_id: &str, device_id: &str,
account_type: OlmAccountType, account_type: OlmAccountType,
) -> Result<usize, Error> { ) -> Result<usize, Error> {
use crate::constants::devices_table; use crate::constants::devices_table;
▲ Show 20 Lines • Show All 142 Lines • Show Last 20 Lines