Page MenuHomePhabricator
Differential D11827

[identity] add span tracing to identity database.rs file
ClosedPublic
Actions

Authored by will on Sun, Apr 28, 11:05 PM.
Tags
None
Referenced Files
F1757169: D11827.id39944.diff
Tue, May 14, 11:45 AM
Unknown Object (File)
Mon, May 13, 10:36 PM
Unknown Object (File)
Sat, May 11, 8:23 PM
Unknown Object (File)
Tue, May 7, 2:01 AM
Unknown Object (File)
Mon, May 6, 11:13 PM
Unknown Object (File)
Sat, May 4, 9:43 AM
Unknown Object (File)
Sat, May 4, 9:20 AM
Unknown Object (File)
Thu, May 2, 7:17 PM
View All 11 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMMb0272d49b183: [identity] add span tracing to identity database.rs file
Summary

Adds span tracing to the database.rs file

Depends on D11826

Test Plan

cargo check

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Sun, Apr 28, 11:05 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSun, Apr 28, 11:05 PM
will added a child revision: D11828: [identity] add span tracing to identity device_list.rs functions.Sun, Apr 28, 11:06 PM
Harbormaster completed remote builds in B28550: Diff 39606.Sun, Apr 28, 11:20 PM
will requested review of this revision.Sun, Apr 28, 11:20 PM
varun accepted this revision.Mon, Apr 29, 10:45 AM
This revision is now accepted and ready to land.Mon, Apr 29, 10:45 AM
bartek accepted this revision.Sun, May 5, 10:40 PM
bartek added inline comments.
services/identity/src/database.rs
1031 ↗(On Diff #39606)

I don't think we need it here. It's an inner helper function

will updated this revision to Diff 39861.Mon, May 6, 9:42 AM

review feedback

will marked an inline comment as done.Mon, May 6, 9:42 AM
Harbormaster completed remote builds in B28711: Diff 39861.Mon, May 6, 9:58 AM
Closed by commit rCOMMb0272d49b183: [identity] add span tracing to identity database.rs file (authored by will). · Explain WhyWed, May 8, 10:33 AM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMMb0272d49b183: [identity] add span tracing to identity database.rs file.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
5 lines

Diff 39944

View Options

services/identity/src/database.rs

Loading...