Page MenuHomePhabricator

[lib] extend message store ops to handle processing local field ops
ClosedPublic

Authored by ginsu on Sat, May 25, 4:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 15, 7:00 PM
Unknown Object (File)
Fri, Jun 14, 11:58 AM
Unknown Object (File)
Wed, Jun 12, 4:55 PM
Unknown Object (File)
Mon, Jun 10, 10:35 AM
Unknown Object (File)
Sun, Jun 9, 10:37 PM
Unknown Object (File)
Sun, Jun 9, 4:33 PM
Unknown Object (File)
Sat, Jun 8, 4:05 PM
Unknown Object (File)
Fri, Jun 7, 8:53 PM
Subscribers

Details

Summary

introduce necessary types + extend message store ops to handle processing local field using ops approach

Depends on D12214

Test Plan

flow + tested the entire stack at the end of the hackathon

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu requested review of this revision.Sat, May 25, 4:58 AM
kamil added inline comments.
lib/types/message-types.js
507 ↗(On Diff #40654)

localMessageInfo - the naming convention is inconsistent with e.g. start_reached but in other stores, we use camel case so probably it's fine. At least we can create a task to make it consistent someday but guessing this task will die in backlog and we'll never prioritize it

This revision is now accepted and ready to land.Mon, May 27, 2:55 AM
This revision was landed with ongoing or failed builds.Wed, Jun 5, 10:26 AM
This revision was automatically updated to reflect the committed changes.