Paths

Table of Contentst

Differential D12215

[lib] extend message store ops to handle processing local field ops
ClosedPublic
Actions

Authored by ginsu on May 25 2024, 4:31 AM.

Tags

None

Referenced Files

	F2114632: D12215.diff
	Wed, Jun 26, 6:03 AM

	Unknown Object (File)
	Mon, Jun 24, 4:45 PM

	Unknown Object (File)
	Thu, Jun 20, 4:47 AM

	Unknown Object (File)
	Wed, Jun 19, 9:39 AM

	Unknown Object (File)
	Wed, Jun 19, 9:13 AM

	Unknown Object (File)
	Sat, Jun 15, 7:00 PM

	Unknown Object (File)
	Fri, Jun 14, 11:58 AM

	Unknown Object (File)
	Wed, Jun 12, 4:55 PM

View All 25 Files

Subscribers

Details

Reviewers

tomek
kamil
will

Commits

rCOMMa6595f319877: [lib] extend message store ops to handle processing local field ops

Summary

introduce necessary types + extend message store ops to handle processing local field using ops approach

Depends on D12214

Test Plan

flow + tested the entire stack at the end of the hackathon

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.May 25 2024, 4:31 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 25 2024, 4:31 AM

ginsu edited the summary of this revision. (Show Details)May 25 2024, 4:32 AM

ginsu added reviewers: tomek, kamil, will.

ginsu added a parent revision: D12214: [lib] reverse conditional logic for convertOpsToClientDBOps in message store ops.

Harbormaster completed remote builds in B29248: Diff 40654.May 25 2024, 4:58 AM

ginsu requested review of this revision.May 25 2024, 4:58 AM

kamil accepted this revision.May 27 2024, 2:55 AM

kamil added inline comments.

lib/types/message-types.js
507 ↗	(On Diff #40654)	`localMessageInfo` - the naming convention is inconsistent with e.g. `start_reached` but in other stores, we use camel case so probably it's fine. At least we can create a task to make it consistent someday but guessing this task will die in backlog and we'll never prioritize it

This revision is now accepted and ready to land.May 27 2024, 2:55 AM

will added a child revision: D12247: [sqlite] create message store local table.Thu, May 30, 8:10 AM

ginsu added inline comments.Wed, Jun 5, 10:16 AM

lib/types/message-types.js
507 ↗	(On Diff #40654)	Created this task to track https://linear.app/comm/issue/ENG-8373/update-fields-in-clientdbmessageinfo-and-clientdbthreadmessageinfo-to

rebase before landing

This revision was landed with ongoing or failed builds.Wed, Jun 5, 10:26 AM

Closed by commit rCOMMa6595f319877: [lib] extend message store ops to handle processing local field ops (authored by ginsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMa6595f319877: [lib] extend message store ops to handle processing local field ops.

Harbormaster completed remote builds in B29457: Diff 40987.Wed, Jun 5, 10:34 AM

Revision Contents
Changeset List

Path

Size

lib/

ops/

message-store-ops.js

54 lines

types/

message-types.js

15 lines

Diff 40989

lib/ops/message-store-ops.js

Loading...

lib/types/message-types.js

Loading...