Page MenuHomePhabricator

[lib] assert function and setting client db with sqlite data
ClosedPublic

Authored by will on Mon, Jun 10, 11:29 AM.
Tags
None
Referenced Files
F2030790: D12384.id41173.diff
Tue, Jun 18, 12:15 AM
F2030789: D12384.id41172.diff
Tue, Jun 18, 12:15 AM
F2026319: D12384.diff
Mon, Jun 17, 3:39 PM
Unknown Object (File)
Fri, Jun 14, 5:35 AM
Unknown Object (File)
Mon, Jun 10, 6:44 PM
Unknown Object (File)
Mon, Jun 10, 6:25 PM
Subscribers

Details

Summary

Populates the client db with message store local sqlite data and includes an assert function to verify the result of message store local operations

Depends on D12370

Test Plan

Tested on both native and web by

  1. launching app on prior migration version
  2. Failing to send several messages by disconnecting the keyserver
  3. Restarting app to confirm assertion between redux persist and sqlite data failure
  4. Running migration
  5. Verifying assertion now passes

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will requested review of this revision.Mon, Jun 10, 11:49 AM
tomek added inline comments.
lib/reducers/message-reducer.test.js
301 ↗(On Diff #41173)

What is the reason behind this change?

This revision is now accepted and ready to land.Tue, Jun 11, 2:36 AM
will planned changes to this revision.Tue, Jun 11, 2:27 PM

Realized this diff requires a critical change of using the action payload sqlite data

lib/reducers/message-reducer.test.js
301 ↗(On Diff #41173)

I did this to reflect how we handle messageStoreThreads where messageStoreThreads is actually converted into a map in the message reducer instead of in native/data/sqlite-data-handler.js

This diff actually uses sqlite data

This revision is now accepted and ready to land.Tue, Jun 11, 3:53 PM
will requested review of this revision.Tue, Jun 11, 4:08 PM
tomek added inline comments.
lib/reducers/message-reducer.js
1630 ↗(On Diff #41227)

This transformation should probably be performed before dispatching setClientDBStoreActionType as we do for other data.

This revision is now accepted and ready to land.Wed, Jun 12, 4:17 AM

set web app start to use sqlite