Page MenuHomePhabricator
Differential D12384

[lib] assert function and setting client db with sqlite data
ClosedPublic
Actions

Authored by will on Jun 10 2024, 11:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 4:22 PM
Unknown Object (File)
Tue, Nov 12, 4:16 PM
Unknown Object (File)
Tue, Nov 12, 3:07 PM
Unknown Object (File)
Tue, Nov 12, 2:46 PM
Unknown Object (File)
Fri, Nov 8, 7:14 PM
Unknown Object (File)
Fri, Nov 8, 7:14 PM
Unknown Object (File)
Fri, Nov 8, 7:14 PM
Unknown Object (File)
Fri, Nov 8, 1:52 PM
View All Files
Subscribers
ashoat
ginsu

Details

Reviewers
tomek
kamil
ginsu
Commits
rCOMM23c6aa4e6c09: [lib] assert function and setting client db with sqlite data
Summary

Populates the client db with message store local sqlite data and includes an assert function to verify the result of message store local operations

Depends on D12370

Test Plan

Tested on both native and web by

  1. launching app on prior migration version
  2. Failing to send several messages by disconnecting the keyserver
  3. Restarting app to confirm assertion between redux persist and sqlite data failure
  4. Running migration
  5. Verifying assertion now passes

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Jun 10 2024, 11:29 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJun 10 2024, 11:29 AM
will updated this revision to Diff 41173.Jun 10 2024, 11:32 AM

remove whitespace

Harbormaster completed remote builds in B29581: Diff 41172.Jun 10 2024, 11:47 AM
Harbormaster completed remote builds in B29582: Diff 41173.
will requested review of this revision.Jun 10 2024, 11:49 AM
will edited the summary of this revision. (Show Details)Jun 10 2024, 11:53 AM
tomek accepted this revision.Jun 11 2024, 2:36 AM
tomek added inline comments.
lib/reducers/message-reducer.test.js
301 ↗(On Diff #41173)

What is the reason behind this change?

This revision is now accepted and ready to land.Jun 11 2024, 2:36 AM
will planned changes to this revision.Jun 11 2024, 2:27 PM

Realized this diff requires a critical change of using the action payload sqlite data

will added a reviewer: ginsu.Jun 11 2024, 2:27 PM
will added a subscriber: ginsu.
will added inline comments.Jun 11 2024, 2:32 PM
lib/reducers/message-reducer.test.js
301 ↗(On Diff #41173)

I did this to reflect how we handle messageStoreThreads where messageStoreThreads is actually converted into a map in the message reducer instead of in native/data/sqlite-data-handler.js

will updated this revision to Diff 41227.Jun 11 2024, 3:53 PM

This diff actually uses sqlite data

This revision is now accepted and ready to land.Jun 11 2024, 3:53 PM
will edited the test plan for this revision. (Show Details)Jun 11 2024, 3:54 PM
will requested review of this revision.Jun 11 2024, 4:08 PM
Harbormaster completed remote builds in B29615: Diff 41227.Jun 11 2024, 4:11 PM
ginsu mentioned this in D12358: [lib] update message reducer to use ops approach for local field.Jun 11 2024, 10:27 PM
tomek accepted this revision.Jun 12 2024, 4:17 AM
tomek added inline comments.
lib/reducers/message-reducer.js
1630 ↗(On Diff #41227)

This transformation should probably be performed before dispatching setClientDBStoreActionType as we do for other data.

This revision is now accepted and ready to land.Jun 12 2024, 4:17 AM
will updated this revision to Diff 41249.Jun 12 2024, 12:17 PM

review feedback

Harbormaster failed remote builds in B29628: Diff 41249!Jun 12 2024, 12:22 PM
will updated this revision to Diff 41252.Jun 12 2024, 12:36 PM

rebase

will edited the test plan for this revision. (Show Details)Jun 12 2024, 12:39 PM
Harbormaster completed remote builds in B29631: Diff 41252.Jun 12 2024, 12:52 PM
will updated this revision to Diff 41253.Jun 12 2024, 1:40 PM

set web app start to use sqlite

Harbormaster completed remote builds in B29632: Diff 41253.Jun 12 2024, 1:57 PM
will added a child revision: D12409: [lib] Use sqlite for message store local instead of redux persist.Jun 12 2024, 2:03 PM
will edited the test plan for this revision. (Show Details)Jun 12 2024, 2:18 PM
Closed by commit rCOMM23c6aa4e6c09: [lib] assert function and setting client db with sqlite data (authored by will). · Explain WhyJun 12 2024, 2:20 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM23c6aa4e6c09: [lib] assert function and setting client db with sqlite data.

Revision Contents
Changeset List

PathSize
lib/
reducers/
7 lines
41 lines
utils/
16 lines
native/
data/
6 lines
web/
shared-worker/
utils/
13 lines

Diff 41256

View Options

lib/reducers/master-reducer.js

Loading...
View Options

lib/reducers/message-reducer.js

Loading...
View Options

lib/utils/message-ops-utils.js

Loading...
View Options

native/data/sqlite-data-handler.js

Loading...
View Options

web/shared-worker/utils/store.js

Loading...