Page MenuHomePhabricator

[lib] Use sqlite for message store local instead of redux persist
Needs RevisionPublic

Authored by will on Wed, Jun 12, 2:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 18, 4:13 PM
Unknown Object (File)
Tue, Jun 18, 2:43 AM
Unknown Object (File)
Tue, Jun 18, 2:05 AM
Unknown Object (File)
Mon, Jun 17, 10:27 AM
Unknown Object (File)
Sun, Jun 16, 5:55 AM
Unknown Object (File)
Sat, Jun 15, 5:20 PM
Subscribers

Details

Reviewers
tomek
kamil
Summary

This diff is in anticipation for when we want to use sqlite for message store local instead of redux persist. This should only be landed after the message store local sqlite diffs have been landed on master for a while and no errors are confirmed with the assertion function.

Depends on D12384

Test Plan

When landing, will verify that the sqlite data is properly reflected on app start on both native and web

Diff Detail

Repository
rCOMM Comm
Branch
sqlite/local_message_store
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will requested review of this revision.Wed, Jun 12, 2:20 PM
tomek requested changes to this revision.Thu, Jun 13, 3:56 AM

It might be a good idea to create a task tracking landing this.

lib/reducers/message-reducer.js
1781

Are you really sure that messageStore will contain local messages from the payload? It looks like we're using them only in !payloadMessages case.

This revision now requires changes to proceed.Thu, Jun 13, 3:56 AM