Page MenuHomePhabricator
Differential D12357

[web] handle message store local ops types in processMessageStoreOperations
ClosedPublic
Actions

Authored by ginsu on Jun 7 2024, 4:49 PM.
Tags
None
Referenced Files
F3486794: D12357.id41166.diff
Wed, Dec 18, 5:57 AM
F3486793: D12357.id41165.diff
Wed, Dec 18, 5:57 AM
F3486792: D12357.id41132.diff
Wed, Dec 18, 5:57 AM
F3486788: D12357.id.diff
Wed, Dec 18, 5:57 AM
F3486787: D12357.diff
Wed, Dec 18, 5:57 AM
Unknown Object (File)
Sat, Nov 23, 8:08 AM
Unknown Object (File)
Nov 13 2024, 7:58 PM
Unknown Object (File)
Nov 12 2024, 4:46 PM
View All 72 Files
Subscribers
ashoat
tomek

Details

Reviewers
will
tomek
kamil
Commits
rCOMM8f0e43bb25ee: [web] handle message store local ops types in processMessageStoreOperations
Summary

We need to update processMessageStoreOperations to handle the local message operation types

Depends on D12253

Test Plan

Confirmed that when processing message store ops on web we were successfully handling the new local message operation types

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Jun 7 2024, 4:49 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 7 2024, 4:49 PM
ginsu added reviewers: will, tomek, kamil.Jun 7 2024, 4:50 PM
ginsu edited the summary of this revision. (Show Details)
ginsu added a parent revision: D12253: [sqlite] implement logic to get message store logic from SQLite.
ginsu added a child revision: D12358: [lib] update message reducer to use ops approach for local field.Jun 7 2024, 5:03 PM
Harbormaster completed remote builds in B29545: Diff 41132.Jun 7 2024, 5:06 PM
ginsu requested review of this revision.Jun 7 2024, 5:06 PM
tomek accepted this revision.Jun 10 2024, 3:19 AM
tomek added inline comments.
web/shared-worker/worker/process-operations.js
306–308 ↗(On Diff #41132)

In most of the other replace ops, we have an ID and an entry as a payload. Should we take a similar approach here?

This revision is now accepted and ready to land.Jun 10 2024, 3:19 AM
ginsu updated this revision to Diff 41165.Jun 10 2024, 7:28 AM

address comments

Harbormaster completed remote builds in B29575: Diff 41165.Jun 10 2024, 7:48 AM
Closed by commit rCOMM8f0e43bb25ee: [web] handle message store local ops types in processMessageStoreOperations (authored by ginsu). · Explain WhyJun 10 2024, 8:34 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM8f0e43bb25ee: [web] handle message store local ops types in processMessageStoreOperations.

Revision Contents
Changeset List

PathSize
web/
shared-worker/
worker/
11 lines

Diff 41166

View Options

web/shared-worker/worker/process-operations.js

Loading...