Page MenuHomePhabricator

[web] handle message store local ops types in processMessageStoreOperations
ClosedPublic

Authored by ginsu on Jun 7 2024, 4:49 PM.
Tags
None
Referenced Files
F3486794: D12357.id41166.diff
Wed, Dec 18, 5:57 AM
F3486793: D12357.id41165.diff
Wed, Dec 18, 5:57 AM
F3486792: D12357.id41132.diff
Wed, Dec 18, 5:57 AM
F3486788: D12357.id.diff
Wed, Dec 18, 5:57 AM
F3486787: D12357.diff
Wed, Dec 18, 5:57 AM
Unknown Object (File)
Sat, Nov 23, 8:08 AM
Unknown Object (File)
Nov 13 2024, 7:58 PM
Unknown Object (File)
Nov 12 2024, 4:46 PM
Subscribers

Details

Summary

We need to update processMessageStoreOperations to handle the local message operation types

Depends on D12253

Test Plan

Confirmed that when processing message store ops on web we were successfully handling the new local message operation types

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu requested review of this revision.Jun 7 2024, 5:06 PM
tomek added inline comments.
web/shared-worker/worker/process-operations.js
306–308 ↗(On Diff #41132)

In most of the other replace ops, we have an ID and an entry as a payload. Should we take a similar approach here?

This revision is now accepted and ready to land.Jun 10 2024, 3:19 AM