Details

Reviewers

tomek
kamil
will

Commits

rCOMM59f8c4f6cbd0: [native/web] introduce migration to move local message info to sqlite

Summary

This migration moves + saves any existing local message infos into sqlite

Depends on D12358

Test Plan

Created some failed sent local messages, ran migrations and confirmed that the there are db rows in the local message client db for each failed message. Double checked in redux dev tools that the migrations ran successfully and additionally assertMessageStoreLocalMessageInfosAreEqual (which gets introduced in the next diff in this stack) does not throw errors whenever I open the app

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Sun, Jun 9, 11:02 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSun, Jun 9, 11:03 PM

ginsu retitled this revision from [native/web] introduce migration to move local message info to sqlite to DRAFT [native/web] introduce migration to move local message info to sqlite.Sun, Jun 9, 11:09 PM

ginsu edited the summary of this revision. (Show Details)

ginsu added a subscriber: will.

Harbormaster completed remote builds in B29563: Diff 41150.Sun, Jun 9, 11:19 PM

ginsu requested review of this revision.Sun, Jun 9, 11:19 PM

will added a child revision: D12384: [lib] assert function and setting client db with sqlite data.Mon, Jun 10, 11:29 AM

update

ginsu edited the summary of this revision. (Show Details)Mon, Jun 10, 11:15 PM

ginsu added a reviewer: tomek.

ginsu added a parent revision: D12358: [lib] update message reducer to use ops approach for local field.

Harbormaster completed remote builds in B29595: Diff 41199.Mon, Jun 10, 11:25 PM

rebase

ginsu retitled this revision from DRAFT [native/web] introduce migration to move local message info to sqlite to [native/web] introduce migration to move local message info to sqlite.Tue, Jun 11, 10:40 PM

ginsu edited the summary of this revision. (Show Details)

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: kamil, will.

ginsu edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B29617: Diff 41229.Tue, Jun 11, 10:49 PM

tomek accepted this revision.Wed, Jun 12, 4:11 AM

This revision is now accepted and ready to land.Wed, Jun 12, 4:11 AM

rebase before landing

Harbormaster completed remote builds in B29627: Diff 41246.Wed, Jun 12, 11:46 AM

Closed by commit rCOMM59f8c4f6cbd0: [native/web] introduce migration to move local message info to sqlite (authored by ginsu). · Explain WhyWed, Jun 12, 11:50 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM59f8c4f6cbd0: [native/web] introduce migration to move local message info to sqlite.