[lib] Use sqlite for message store local instead of redux persist
ClosedPublic
Actions

Authored by will on Jun 12 2024, 2:03 PM.

Details

Reviewers

tomek
kamil

Commits

rCOMM1fb9b351f16c: [lib] Use sqlite for message store local instead of redux persist

Summary

This diff is in anticipation for when we want to use sqlite for message store local instead of redux persist. This should only be landed after the message store local sqlite diffs have been landed on master for a while and no errors are confirmed with the assertion function.

Depends on D12384

Test Plan

When landing, will verify that the sqlite data is properly reflected on app start on both native and web

Diff Detail

Repository

rCOMM Comm

Branch

sqlite/local_message_store

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Jun 12 2024, 2:03 PM

Herald added a subscriber: ashoat. · View Herald TranscriptJun 12 2024, 2:03 PM

Harbormaster completed remote builds in B29633: Diff 41254.Jun 12 2024, 2:20 PM

will requested review of this revision.Jun 12 2024, 2:20 PM

It might be a good idea to create a task tracking landing this.

lib/reducers/message-reducer.js
1781 ↗	(On Diff #41254)	Are you really sure that `messageStore` will contain local messages from the payload? It looks like we're using them only in `!payloadMessages` case.

This revision now requires changes to proceed.Jun 13 2024, 3:56 AM

return local messages when there are payloadMessages

will added inline comments.Aug 13 2024, 4:17 PM

lib/reducers/message-reducer.js
1781 ↗	(On Diff #41254)	You're correct. Took another look and it looks like all that needs to be done is including the action payload local messages as part of `updatedMessageStore` which are then included as part of the new message store and the processed messages store