[lib] Narrow `threadInfo` argument of `threadFrozenDueToViewerBlock`
ClosedPublic
Actions

Authored by atul on Jun 1 2024, 10:00 PM.

Details

Reviewers

ashoat
ginsu
tomek
varun

Commits

rCOMMc2da721a842f: [lib] Narrow `threadInfo` argument of `threadFrozenDueToViewerBlock`

Summary

This change is kind of useless. Thought I'd be able to do a lot more narrowing of types "along" the memberHasAdminPowers callstack, but this was pretty much it. Figured I may as well put it up.

Depends on D12265

Test Plan

NA, flow

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jun 1 2024, 10:00 PM

Harbormaster completed remote builds in B29343: Diff 40823.Jun 1 2024, 10:17 PM

atul requested review of this revision.Jun 1 2024, 10:17 PM

ashoat accepted this revision.Jun 2 2024, 2:09 PM

This revision is now accepted and ready to land.Jun 2 2024, 2:09 PM

rebase and land

Harbormaster completed remote builds in B29390: Diff 40889.Jun 3 2024, 11:42 AM

Closed by commit rCOMMc2da721a842f: [lib] Narrow `threadInfo` argument of `threadFrozenDueToViewerBlock` (authored by atul). · Explain WhyJun 3 2024, 12:08 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMc2da721a842f: [lib] Narrow `threadInfo` argument of `threadFrozenDueToViewerBlock`.

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

4 lines

Diff 40823

View Options

lib/shared/thread-utils.js

This file was added.

				// @flow

				import type {
				StackNavigationEventMap,
				StackNavigationState,
				StackOptions,
				} from '@react-navigation/core';
				import * as React from 'react';
				import { Text } from 'react-native';

				import { type QRAuthNavigationProp } from './qr-auth-navigator.react.js';
				import RegistrationButtonContainer from '../../account/registration/registration-button-container.react.js';
				import RegistrationContainer from '../../account/registration/registration-container.react.js';
				import RegistrationContentContainer from '../../account/registration/registration-content-container.react.js';
				import PrimaryButton from '../../components/primary-button.react.js';
				import type { RootNavigationProp } from '../../navigation/root-navigator.react.js';
				import {
				type NavigationRoute,
				type ScreenParamList,
				} from '../../navigation/route-names.js';
				import { useStyles } from '../../themes/colors.js';

				type Props = {
				+navigation: QRAuthNavigationProp<'QRAuthNotPrimaryDevice'>,
				+route: NavigationRoute<'QRAuthNotPrimaryDevice'>,
				};

				function QRAuthNotPrimaryDevice(prop: Props): React.Node {
				const { navigation } = prop;
				const styles = useStyles(unboundStyles);

				const onPressGoBack = React.useCallback(() => {
				navigation
				.getParent<
				ScreenParamList,
				'LinkedDevicesBottomSheet',
				StackNavigationState,
				StackOptions,
				StackNavigationEventMap,
				RootNavigationProp<'LinkedDevicesBottomSheet'>,
				>()
				?.goBack();
				}, [navigation]);

				return (
				<RegistrationContainer>
				<RegistrationContentContainer>
				<Text style={styles.header}>Device not primary</Text>
				<Text style={styles.body}>
				This mobile device is not your primary device, and cannot be used to
				authorize new devices. Please try your other mobile device(s).
				</Text>
				</RegistrationContentContainer>
				<RegistrationButtonContainer>
				<PrimaryButton
				onPress={onPressGoBack}
				label="Go back"
				variant="enabled"
				/>
				</RegistrationButtonContainer>
				</RegistrationContainer>
				);
				}

				const unboundStyles = {
				header: {
				fontSize: 24,
				color: 'panelForegroundLabel',
				paddingBottom: 16,
				},
				body: {
				fontFamily: 'Arial',
				fontSize: 15,
				lineHeight: 20,
				color: 'panelForegroundSecondaryLabel',
				paddingBottom: 16,
				},
				};

				export default QRAuthNotPrimaryDevice;

[lib] Narrow `threadInfo` argument of `threadFrozenDueToViewerBlock`ClosedPublicActions