This allows us to narrow things as threadIsWithBlockedUserOnlyWithoutAdminRoleCheck only accepts ThreadInfo and will help us remove ThreadInfo from memberHasAdminPowers.memberInfo argument without that invariant.
Depends on D12289
Details
Details
flow + close reading
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/shared/thread-utils.js | ||
|---|---|---|
| 179 ↗ | (On Diff #40899) | What was set to true here was skipMemberAdminRoleCheck option. The checkOnlyViewerBlock option was set within innerThreadFrozenDueToBlock. |
| 179 ↗ | (On Diff #40899) | What is set to false here is the checkOnlyViewerBlock option, there's no skipMemberAdminRoleCheck option when calling threadIsWithBlockedUserOnlyWithoutAdminRoleCheck because the whole point is that we only accept ThreadInfo and handle admin role check separately. |
| lib/shared/thread-utils.js | ||
|---|---|---|
| 179 ↗ | (On Diff #40899) | Can we introduce an object param instead of multiple params with an unobvious meaning? |
| lib/shared/thread-utils.js | ||
|---|---|---|
| 179 ↗ | (On Diff #40899) | We actually introduced and un-introduced object param in this stack, there's just one option now. |