[commtest] Add default impl for ClientPublicKeys
ClosedPublic
Actions

Authored by bartek on Jun 6 2024, 11:29 PM.

Details

Reviewers

kamil
will
varun
marcin

Commits

rCOMM8d2fc8dfbb85: [commtest] Add default impl for ClientPublicKeys

Summary

Some improvement to the ClientPublicKeys type:

Added new() function that creates keys with given device ID
Added default() which uses random device ID

Test Plan

Commtest. This is used in other diffs

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jun 6 2024, 11:29 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 6 2024, 11:29 PM

bartek added a child revision: D12341: [commtest] Generate random client keys by default.Jun 6 2024, 11:31 PM

Harbormaster failed remote builds in B29510: Diff 41083!Jun 6 2024, 11:35 PM

Keyserver CI unrelated

Harbormaster completed remote builds in B29510: Diff 41083.Jun 9 2024, 11:24 PM

kamil accepted this revision.Jun 10 2024, 10:11 AM

This revision is now accepted and ready to land.Jun 10 2024, 10:11 AM

Closed by commit rCOMM8d2fc8dfbb85: [commtest] Add default impl for ClientPublicKeys (authored by bartek). · Explain WhyJun 12 2024, 7:31 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM8d2fc8dfbb85: [commtest] Add default impl for ClientPublicKeys.

Revision Contents
Changeset List

Path

Size

services/

commtest/

src/

identity/

olm_account_infos.rs

21 lines

Diff 41232

View Options

services/commtest/src/identity/olm_account_infos.rs

[commtest] Add default impl for ClientPublicKeysClosedPublicActions