Details

Reviewers

kamil
will
varun
marcin

Commits

rCOMM8d7e41dd83d6: [commtest] Generate random client keys by default

Summary

Depends on D12340.

First step to get rid of hardcoded device IDs
Made login and register functions use ClientPublicKeys default implementation from D12340, if no explicit keys provided.

Test Plan

Commtest

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jun 7 2024, 6:31 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 7 2024, 6:31 AM

bartek added a child revision: D12342: [commtest] Make ClientPublicKeys::device_id() return str slice.Jun 7 2024, 6:32 AM

Harbormaster failed remote builds in B29511: Diff 41084!Jun 7 2024, 6:36 AM

Rebase on test fix

bartek added a parent revision: D12346: [commtest] Fix flaky identity-tunnelbroker test.Jun 7 2024, 8:08 AM

Harbormaster failed remote builds in B29517: Diff 41090!Jun 7 2024, 8:12 AM

bartek published this revision for review.Jun 7 2024, 8:59 AM

Harbormaster completed remote builds in B29517: Diff 41090.Jun 10 2024, 6:26 AM

kamil accepted this revision.Jun 10 2024, 5:12 PM

This revision is now accepted and ready to land.Jun 10 2024, 5:12 PM

Closed by commit rCOMM8d7e41dd83d6: [commtest] Generate random client keys by default. · Explain WhyJun 12 2024, 2:31 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM8d7e41dd83d6: [commtest] Generate random client keys by default.

[commtest] Generate random client keys by default
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 41234

services/commtest/src/identity/device.rs

services/commtest/src/identity/mod.rs

[commtest] Generate random client keys by defaultClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 41234

services/commtest/src/identity/device.rs

services/commtest/src/identity/mod.rs

[commtest] Generate random client keys by default
ClosedPublic
Actions

Revision Contents
Changeset List