Paths

Table of Contentst

[commtest] Generate random client keys by default
ClosedPublic
Actions

Authored by bartek on Jun 6 2024, 11:31 PM.

Details

Reviewers

kamil
will
varun
marcin

Commits

rCOMM8d7e41dd83d6: [commtest] Generate random client keys by default

Summary

Depends on D12340.

First step to get rid of hardcoded device IDs
Made login and register functions use ClientPublicKeys default implementation from D12340, if no explicit keys provided.

Test Plan

Commtest

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Jun 6 2024, 11:31 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 6 2024, 11:31 PM

bartek added a child revision: D12342: [commtest] Make ClientPublicKeys::device_id() return str slice.Jun 6 2024, 11:32 PM

Harbormaster failed remote builds in B29511: Diff 41084!Jun 6 2024, 11:36 PM

Rebase on test fix

bartek added a parent revision: D12346: [commtest] Fix flaky identity-tunnelbroker test.Jun 7 2024, 1:08 AM

Harbormaster failed remote builds in B29517: Diff 41090!Jun 7 2024, 1:12 AM

bartek published this revision for review.Jun 7 2024, 1:59 AM

Harbormaster completed remote builds in B29517: Diff 41090.Jun 9 2024, 11:26 PM

kamil accepted this revision.Jun 10 2024, 10:12 AM

This revision is now accepted and ready to land.Jun 10 2024, 10:12 AM

Closed by commit rCOMM8d7e41dd83d6: [commtest] Generate random client keys by default (authored by bartek). · Explain WhyJun 12 2024, 7:31 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM8d7e41dd83d6: [commtest] Generate random client keys by default.

Revision Contents
Changeset List

Path

Size

services/

commtest/

src/

identity/

device.rs

22 lines

mod.rs

14 lines

Diff 41084

View Options

services/commtest/src/identity/device.rs