Page MenuHomePhabricator
Differential D12343

[commtest] Get rid of hardcoded ClientPublicKeys values
ClosedPublic
Actions

Authored by bartek on Thu, Jun 6, 11:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 2, 2:06 PM
Unknown Object (File)
Sat, Jun 29, 10:08 PM
Unknown Object (File)
Sat, Jun 29, 2:40 AM
Unknown Object (File)
Thu, Jun 27, 5:18 AM
Unknown Object (File)
Mon, Jun 24, 2:35 PM
Unknown Object (File)
Mon, Jun 24, 2:24 PM
Unknown Object (File)
Fri, Jun 21, 4:45 PM
Unknown Object (File)
Thu, Jun 20, 11:41 AM
View All 29 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
will
varun
marcin
Commits
rCOMM1869f7cedecc: [commtest] Get rid of hardcoded ClientPublicKeys values
Summary

Depends on D12342

Removed hardcoded ClientPublicKeys constants and replaced usages with new implementation

Test Plan

Commtest

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Thu, Jun 6, 11:34 PM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Jun 6, 11:34 PM
bartek added a child revision: D12344: [commtest] Rename SigningCapableAccount to MockOlmAccount.Thu, Jun 6, 11:35 PM
Harbormaster failed remote builds in B29513: Diff 41086!Thu, Jun 6, 11:38 PM
bartek updated this revision to Diff 41091.Fri, Jun 7, 1:36 AM

Try rebase on flaky test fix

Harbormaster failed remote builds in B29518: Diff 41091!Fri, Jun 7, 1:42 AM
bartek published this revision for review.Fri, Jun 7, 4:03 AM

Keyserver CI unrelated

Harbormaster completed remote builds in B29518: Diff 41091.Sun, Jun 9, 11:26 PM
kamil accepted this revision.Mon, Jun 10, 10:14 AM

Nice to see that 👏

This revision is now accepted and ready to land.Mon, Jun 10, 10:14 AM
Closed by commit rCOMM1869f7cedecc: [commtest] Get rid of hardcoded ClientPublicKeys values (authored by bartek). · Explain WhyWed, Jun 12, 7:31 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM1869f7cedecc: [commtest] Get rid of hardcoded ClientPublicKeys values.

Revision Contents
Changeset List

Diff 41236

View Options

services/commtest/src/identity/olm_account_infos.rs

Loading...
View Options

services/commtest/tests/identity_device_list_tests.rs

Loading...
View Options

services/commtest/tests/tunnelbroker_integration_tests.rs

Loading...
View Options

services/commtest/tests/tunnelbroker_persist_tests.rs

Loading...
View Options

services/commtest/tests/tunnelbroker_recipient_confirmation_tests.rs

Loading...
View Options

services/commtest/tests/tunnelbroker_sender_confirmation_tests.rs

Loading...
View Options

services/commtest/tests/tunnelbroker_websocket_messages_tests.rs

Loading...