Tags

None

Referenced Files

	F2158170: D12399.id.diff
	Mon, Jul 1, 3:19 AM

	Unknown Object (File)
	Sun, Jun 30, 8:29 AM

	Unknown Object (File)
	Sat, Jun 22, 5:20 AM

	Unknown Object (File)
	Sat, Jun 22, 3:59 AM

	Unknown Object (File)
	Fri, Jun 21, 1:24 AM

	Unknown Object (File)
	Thu, Jun 20, 1:08 PM

	Unknown Object (File)
	Thu, Jun 20, 7:12 AM

	Unknown Object (File)
	Thu, Jun 20, 4:51 AM

View All 17 Files

Subscribers

ashoat

Details

Reviewers

inka
ginsu

Commits

rCOMM66a65374c86a: [keyserver] Modify thread join responder to handle thread invite links

Summary

We allow joining a thread when a secret is matched for a community or a thread.

https://linear.app/comm/issue/ENG-8416/modify-thread-join-responder-to-handle-thread-invite-links

Depends on D12393

Test Plan

Tested with the rest of the stack: used an invite link to a thread and verified that the thread was successfully joined.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Tue, Jun 11, 11:11 AM

Herald added a subscriber: ashoat. · View Herald TranscriptTue, Jun 11, 11:11 AM

Harbormaster completed remote builds in B29607: Diff 41216.Tue, Jun 11, 11:29 AM

tomek requested review of this revision.Tue, Jun 11, 11:29 AM

ginsu accepted this revision.Thu, Jun 13, 1:55 AM

This revision is now accepted and ready to land.Thu, Jun 13, 1:55 AM

tomek edited the test plan for this revision. (Show Details)Thu, Jun 13, 4:40 AM

tomek added a child revision: D12420: [native][web] Navigate to a thread if already joined.Thu, Jun 13, 4:46 AM

Closed by commit rCOMM66a65374c86a: [keyserver] Modify thread join responder to handle thread invite links (authored by tomek). · Explain WhyFri, Jun 14, 5:27 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM66a65374c86a: [keyserver] Modify thread join responder to handle thread invite links.

[keyserver] Modify thread join responder to handle thread invite links
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 41325

keyserver/src/fetchers/link-fetchers.js

[keyserver] Modify thread join responder to handle thread invite linksClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 41325

keyserver/src/fetchers/link-fetchers.js

[keyserver] Modify thread join responder to handle thread invite links
ClosedPublic
Actions

Revision Contents
Changeset List