Page MenuHomePhabricator

[lib] Modify the approach to handling invite link acceptance
ClosedPublic

Authored by tomek on Thu, Jun 13, 5:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 27, 11:10 AM
Unknown Object (File)
Wed, Jun 26, 8:23 AM
Unknown Object (File)
Mon, Jun 24, 6:22 PM
Unknown Object (File)
Fri, Jun 21, 6:19 PM
Unknown Object (File)
Thu, Jun 20, 5:35 PM
Unknown Object (File)
Thu, Jun 20, 11:05 AM
Unknown Object (File)
Thu, Jun 20, 6:32 AM
Unknown Object (File)
Thu, Jun 20, 12:03 AM
Subscribers

Details

Summary

Later in the stack we need to join two threads which requires dispatching two success actions - something not possible in the current approach where we create a promise and pass it to a single dispatchActionPromise. In this new approach, we call dispatchActionPromise in an effect which allows adding the second effect later in the stack.

Note: this diff breaks a loading status. It is fixed in the next diff where steps are introduced. This approach is more efficient than fixing it in this diff.

https://linear.app/comm/issue/ENG-8250/join-a-thread-after-joining-a-community

Depends on D12422

Test Plan

Tested in combination with the rest of the stack by checking if joining a community link works.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable