Page MenuHomePhabricator

[keyserver] Extend link validation to support thread links
ClosedPublic

Authored by tomek on Jun 11 2024, 10:00 AM.
Tags
None
Referenced Files
F3356640: D12392.id41325.diff
Sat, Nov 23, 7:45 PM
F3356633: D12392.id41211.diff
Sat, Nov 23, 7:43 PM
Unknown Object (File)
Wed, Nov 13, 11:45 AM
Unknown Object (File)
Thu, Nov 7, 8:00 PM
Unknown Object (File)
Thu, Nov 7, 8:33 AM
Unknown Object (File)
Wed, Nov 6, 12:44 PM
Unknown Object (File)
Fri, Nov 1, 5:38 PM
Unknown Object (File)
Fri, Nov 1, 11:51 AM
Subscribers

Details

Summary

In addition to the previous solution, fetch thread-related data and return the response based on both community and thread data.

https://linear.app/comm/issue/ENG-8249/modify-verify-invite-links-response-to-include-a-thread-id-and-its

Depends on D12354

Test Plan

Checked returned verification status for community and thread links when viewer is and isn't a member.
Also checked if joining a thread link results in joining a community.

These two checks additionally validate that the older client will work correctly with the new solution to links.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable