Page MenuHomePhabricator
Differential D12392

[keyserver] Extend link validation to support thread links
ClosedPublic
Actions

Authored by tomek on Jun 11 2024, 10:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 6:03 AM
Unknown Object (File)
Sun, Nov 24, 2:59 PM
Unknown Object (File)
Sun, Nov 24, 11:51 AM
Unknown Object (File)
Sat, Nov 23, 7:45 PM
Unknown Object (File)
Sat, Nov 23, 7:43 PM
Unknown Object (File)
Wed, Nov 13, 11:45 AM
Unknown Object (File)
Thu, Nov 7, 8:00 PM
Unknown Object (File)
Thu, Nov 7, 8:33 AM
View All Files
Subscribers
ashoat

Details

Reviewers
inka
ginsu
Commits
rCOMM8341afe4c45d: [keyserver] Extend link validation to support thread links
Summary

In addition to the previous solution, fetch thread-related data and return the response based on both community and thread data.

https://linear.app/comm/issue/ENG-8249/modify-verify-invite-links-response-to-include-a-thread-id-and-its

Depends on D12354

Test Plan

Checked returned verification status for community and thread links when viewer is and isn't a member.
Also checked if joining a thread link results in joining a community.

These two checks additionally validate that the older client will work correctly with the new solution to links.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
keyserver/
src/
fetchers/
52 lines
lib/
types/
4 lines
validators/
14 lines

Diff 41209

View Options

keyserver/src/fetchers/link-fetchers.js

Loading...
View Options

lib/types/link-types.js

Loading...
View Options

lib/types/validators/link-validators.js

Loading...