Page MenuHomePhabricator

[lib] Define steps in link acceptance hook
ClosedPublic

Authored by tomek on Thu, Jun 13, 5:38 AM.
Tags
None
Referenced Files
F2158924: D12424.id.diff
Mon, Jul 1, 5:24 AM
Unknown Object (File)
Sat, Jun 29, 12:13 AM
Unknown Object (File)
Thu, Jun 20, 6:35 AM
Unknown Object (File)
Thu, Jun 20, 3:17 AM
Unknown Object (File)
Wed, Jun 19, 11:39 PM
Unknown Object (File)
Wed, Jun 19, 1:11 AM
Unknown Object (File)
Tue, Jun 18, 5:36 PM
Unknown Object (File)
Mon, Jun 17, 10:31 PM
Subscribers

Details

Summary

This makes it easier to reason about the flow and to add a new step.

https://linear.app/comm/issue/ENG-8250/join-a-thread-after-joining-a-community

Depends on D12423

Test Plan

Tested with the rest of the stack. Checked if joining communities still works. Also, added some timeouts in the auth keyserver effect and in the thread join responder and verified that the loading status was correct.

Note: didn't test the secondary keyserver invite links - they don't work currently because of https://linear.app/comm/issue/ENG-7592/invite-links-of-the-secondary-keyserver-dont-work.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable