Page MenuHomePhabricator
Differential D12426

[lib] Extract a file with invite links constants
ClosedPublic
Actions

Authored by tomek on Jun 13 2024, 6:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 12:14 PM
Unknown Object (File)
Fri, Nov 1, 12:14 PM
Unknown Object (File)
Fri, Nov 1, 12:14 PM
Unknown Object (File)
Fri, Nov 1, 12:14 PM
Unknown Object (File)
Sep 25 2024, 10:48 PM
Unknown Object (File)
Sep 25 2024, 10:48 PM
Unknown Object (File)
Sep 25 2024, 10:48 PM
Unknown Object (File)
Sep 25 2024, 10:47 PM
View All 39 Files
Subscribers
ashoat

Details

Reviewers
inka
ginsu
kamil
Commits
rCOMMd4b47f14bc6a: [lib] Extract a file with invite links constants
Summary

We had an import cycle which blocked us from creating invite links from scripts. This diff moves the constants to a new place to break the cycle.

https://linear.app/comm/issue/ENG-8390/fix-creating-invite-links-from-scrips

Depends on D12425

Test Plan

Flow. Try to create a link from a script - there should be no error message about an uninitialized variable.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
keyserver/
src/
creators/
6 lines
responders/
2 lines
lib/
shared/
26 lines
26 lines
utils/
2 lines
native/
invite-links/
2 lines
web/
invite-links/
manage/
2 lines

Diff 41332

View Options

keyserver/src/creators/invite-link-creator.js

Loading...
View Options

keyserver/src/responders/website-responders.js

Loading...
View Options

lib/shared/invite-links-constants.js

Loading...
View Options

lib/shared/invite-links.js

Loading...
View Options

lib/utils/url-utils.js

Loading...
View Options

native/invite-links/manage-public-link-screen.react.js

Loading...
View Options

web/invite-links/manage/edit-link-modal.react.js

Loading...