Details

Reviewers

bartek
tomek
inka
kamil

Commits

rCOMM33730e29f317: Implement peer notifications session creation as outbound on web and add notifs…

Summary

This differential implements outbound notifications session creation on web. It also adds this functionality to OlmAPI so that code in lib can create notifs sessions

Test Plan

Tested in D12673

Diff Detail

Repository

rCOMM Comm

Branch

marcin/eng-8237

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Jul 4 2024, 9:23 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJul 4 2024, 9:23 AM

marcin added a parent revision: D12668: Implement peer notifications session creation as outbound on native.Jul 4 2024, 9:24 AM

marcin added a child revision: D12670: Implement notification encryption on native.

Harbormaster completed remote builds in B30148: Diff 42039.Jul 4 2024, 9:39 AM

marcin requested review of this revision.Jul 4 2024, 9:39 AM

marcin edited the test plan for this revision. (Show Details)Jul 4 2024, 9:44 AM

tomek accepted this revision.Jul 8 2024, 4:12 AM

tomek added inline comments.

lib/types/crypto-types.js
178	Why do we need the content keys?
web/push-notif/notif-crypto-utils.js
441	Should we mention something about notifs in this name?

This revision is now accepted and ready to land.Jul 8 2024, 4:12 AM

marcin added inline comments.Jul 12 2024, 2:22 AM

lib/types/crypto-types.js
178	We need `deviceID` and `deviceID` is the `ed25519` part of `contentInboundKeys`.
web/push-notif/notif-crypto-utils.js
441	I don't think it is necessary since we only store notifs data in IndexedDB.

kamil accepted this revision.Jul 16 2024, 4:32 AM

kamil added a subscriber: kamil.

kamil added inline comments.

lib/types/crypto-types.js
170–180	It's a bit unclear what are differences between these two and which one to use when needed - can we somehow improve naming?
178	that being said I think it's better to just pass `deviceID`, but up to you

Address review

Harbormaster failed remote builds in B30631: Diff 42727!Jul 24 2024, 5:57 AM

Update phab

Harbormaster completed remote builds in B30790: Diff 42935.Jul 30 2024, 3:45 AM

Rebase before landing

Harbormaster completed remote builds in B30892: Diff 43072.Aug 5 2024, 4:34 AM

Closed by commit rCOMM33730e29f317: Implement peer notifications session creation as outbound on web and add notifs… (authored by marcin, committed by Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local>). · Explain WhyAug 5 2024, 6:39 AM

This revision was automatically updated to reflect the committed changes.

Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local> added a commit: rCOMM33730e29f317: Implement peer notifications session creation as outbound on web and add notifs….

Implement peer notifications session creation as outbound on web and add notifs outbound session creator to OlmAPI
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 42039

lib/types/crypto-types.js

lib/utils/mocks/config.js

native/crypto/olm-api.js

web/crypto/olm-api.js

web/push-notif/notif-crypto-utils.js

web/shared-worker/worker/worker-crypto.js

Implement peer notifications session creation as outbound on web and add notifs outbound session creator to OlmAPIClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 42039

lib/types/crypto-types.js

lib/utils/__mocks__/config.js

native/crypto/olm-api.js

web/crypto/olm-api.js

web/push-notif/notif-crypto-utils.js

web/shared-worker/worker/worker-crypto.js

Implement peer notifications session creation as outbound on web and add notifs outbound session creator to OlmAPI
ClosedPublic
Actions

Revision Contents
Changeset List

lib/utils/mocks/config.js