[web][native] update `useSendReaction` to `ThreadInfo` instead of `threadID` only
ClosedPublic
Actions

Authored by kamil on Tue, Aug 27, 4:47 AM.

Details

Reviewers

tomek
inka

Commits

rCOMMf65afe3524f6: [web][native] update `useSendReaction` to `ThreadInfo` instead of `threadID`…

Summary

ENG-8975

For DMs, we need more data - members and check if the thread is thick.

Test Plan

Flow, the reaction still works.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Tue, Aug 27, 4:47 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptTue, Aug 27, 4:47 AM

kamil added a child revision: D13174: [web][native] update `useSendReaction` to send DMs reactions.Tue, Aug 27, 4:48 AM

Harbormaster completed remote builds in B31279: Diff 43671.Tue, Aug 27, 5:04 AM

kamil published this revision for review.Tue, Aug 27, 5:06 AM

kamil edited the summary of this revision. (Show Details)

kamil edited the test plan for this revision. (Show Details)

tomek accepted this revision.Wed, Aug 28, 3:47 AM

This revision is now accepted and ready to land.Wed, Aug 28, 3:47 AM

kamil added a parent revision: D13193: [lib] make it possible to send DM ops to all thread members.Wed, Aug 28, 8:06 AM

Closed by commit rCOMMf65afe3524f6: [web][native] update `useSendReaction` to `ThreadInfo` instead of `threadID`… (authored by kamil). · Explain WhyWed, Aug 28, 8:33 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMf65afe3524f6: [web][native] update `useSendReaction` to `ThreadInfo` instead of `threadID`….

Revision Contents
Changeset List

Path

Size

native/

chat/

inline-engagement.react.js

6 lines

multimedia-message-tooltip-button.react.js

6 lines

reaction-message-utils.js

7 lines

robotext-message-tooltip-button.react.js

6 lines

text-message-tooltip-button.react.js

6 lines

web/

chat/

inline-engagement.react.js

4 lines

reaction-message-utils.js

7 lines

reaction-pill.react.js

7 lines

tooltips/

message-tooltip.react.js

6 lines

Diff 43671

View Options

native/chat/inline-engagement.react.js

View Options

native/chat/multimedia-message-tooltip-button.react.js

View Options

native/chat/reaction-message-utils.js

View Options

native/chat/robotext-message-tooltip-button.react.js

View Options

native/chat/text-message-tooltip-button.react.js

View Options

web/chat/inline-engagement.react.js

View Options

web/chat/reaction-message-utils.js

View Options

web/chat/reaction-pill.react.js

View Options

web/tooltips/message-tooltip.react.js

[web][native] update `useSendReaction` to `ThreadInfo` instead of `threadID` onlyClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43671

native/chat/inline-engagement.react.js

native/chat/multimedia-message-tooltip-button.react.js

native/chat/reaction-message-utils.js

native/chat/robotext-message-tooltip-button.react.js

native/chat/text-message-tooltip-button.react.js

web/chat/inline-engagement.react.js

web/chat/reaction-message-utils.js

web/chat/reaction-pill.react.js

web/tooltips/message-tooltip.react.js

[web][native] update `useSendReaction` to `ThreadInfo` instead of `threadID` only
ClosedPublic
Actions

Revision Contents
Changeset List