Details

Reviewers

kamil
tomek

Commits

rCOMM05f48bd31b3d: JSI to update unread thick thread IDs in MMKV

Summary

This differential implements JSI that allows to set and get unread thick thread IDs from MMKV from JS.

Test Plan

Tested in next diff

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

marcin created this revision.Aug 28 2024, 3:07 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 28 2024, 3:07 AM

marcin added a parent revision: D13188: Add method to set entire sttring set at once in MMKV.Aug 28 2024, 3:07 AM

marcin added a child revision: D13190: Update badge count from JS on native taking into account thick threads.Aug 28 2024, 3:13 AM

Harbormaster completed remote builds in B31319: Diff 43727.Aug 28 2024, 3:43 AM

marcin requested review of this revision.Aug 28 2024, 3:43 AM

tomek accepted this revision.Aug 29 2024, 6:11 AM

tomek added inline comments.

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
1489 ↗	(On Diff #43727)	Can we use a shared constant?

This revision is now accepted and ready to land.Aug 29 2024, 6:11 AM

Share unread thick thread ids set key between C++, Java and Obj-C

Remove remaining usage of hardcoded NOTIFS.UNREAD_THICK_THREADS constant in CommCoreModule.cpp

Harbormaster failed remote builds in B31392: Diff 43837!Sep 2 2024, 9:25 AM

Harbormaster failed remote builds in B31395: Diff 43840!Sep 2 2024, 9:51 AM

Fix iOS compilation

Harbormaster completed remote builds in B31410: Diff 43856.Sep 3 2024, 2:56 AM

Rebase before landing

Harbormaster completed remote builds in B31419: Diff 43865.Sep 3 2024, 8:03 AM

Closed by commit rCOMM05f48bd31b3d: JSI to update unread thick thread IDs in MMKV (authored by Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local>). · Explain WhySep 3 2024, 8:20 AM

This revision was automatically updated to reflect the committed changes.

Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local> added a commit: rCOMM05f48bd31b3d: JSI to update unread thick thread IDs in MMKV.

JSI to update unread thick thread IDs in MMKV
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 43875

native/android/app/CMakeLists.txt

native/android/app/src/cpp/CommMMKVJNIHelper.cpp

native/android/app/src/cpp/jsiInstaller.cpp

native/android/app/src/main/java/app/comm/android/fbjni/CommMMKV.java

native/android/app/src/main/java/app/comm/android/notifications/CommNotificationsHandler.java

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

native/cpp/CommonCpp/Tools/CommMMKV.h

native/cpp/CommonCpp/Tools/CommMMKVJNIHelper.h

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

native/cpp/CommonCpp/_generated/commJSI.h

native/ios/NotificationService/NotificationService.mm

native/schema/CommCoreModuleSchema.js

JSI to update unread thick thread IDs in MMKVClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43875

native/android/app/CMakeLists.txt

native/android/app/src/cpp/CommMMKVJNIHelper.cpp

native/android/app/src/cpp/jsiInstaller.cpp

native/android/app/src/main/java/app/comm/android/fbjni/CommMMKV.java

native/android/app/src/main/java/app/comm/android/notifications/CommNotificationsHandler.java

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

native/cpp/CommonCpp/Tools/CommMMKV.h

native/cpp/CommonCpp/Tools/CommMMKVJNIHelper.h

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

native/cpp/CommonCpp/_generated/commJSI.h

native/ios/NotificationService/NotificationService.mm

native/schema/CommCoreModuleSchema.js

JSI to update unread thick thread IDs in MMKV
ClosedPublic
Actions

Revision Contents
Changeset List