Page MenuHomePhabricator
Differential D13200

[web][native] add test button to create DM thread
ClosedPublic
Actions

Authored by kamil on Aug 28 2024, 8:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 11, 11:46 AM
Unknown Object (File)
Sat, Mar 8, 12:06 AM
Unknown Object (File)
Fri, Mar 7, 5:03 AM
Unknown Object (File)
Mar 4 2025, 10:35 PM
Unknown Object (File)
Mar 4 2025, 10:35 PM
Unknown Object (File)
Mar 4 2025, 10:35 PM
Unknown Object (File)
Mar 4 2025, 10:34 PM
Unknown Object (File)
Mar 4 2025, 10:34 PM
View All 78 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMM02f539bf3356: [web][native] add test button to create DM thread
Summary

This code allows testing DMs on prod for staff. We can create a thread and then using diff from this stack add members and test all DMs features.

Log in/log out erase all DMs data (there is no backup).

Depends on D13199

Test Plan

Check is thread is created

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Aug 28 2024, 8:49 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptAug 28 2024, 8:49 AM
Harbormaster completed remote builds in B31351: Diff 43769.Aug 28 2024, 9:15 AM
kamil published this revision for review.Aug 28 2024, 9:18 AM
tomek accepted this revision.Aug 28 2024, 9:34 AM
tomek added inline comments.
native/profile/profile-screen.react.js
287 ↗(On Diff #43769)
584 ↗(On Diff #43769)

We can also take this from thickThreadTypes

web/settings/account-settings.react.js
303 ↗(On Diff #43769)
This revision is now accepted and ready to land.Aug 28 2024, 9:34 AM
kamil updated this revision to Diff 43780.Aug 29 2024, 12:21 AM

address review

Harbormaster failed remote builds in B31360: Diff 43780!Aug 29 2024, 12:28 AM
Harbormaster completed remote builds in B31360: Diff 43780.Aug 29 2024, 1:01 AM
Closed by commit rCOMM02f539bf3356: [web][native] add test button to create DM thread (authored by kamil). · Explain WhyAug 29 2024, 1:16 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM02f539bf3356: [web][native] add test button to create DM thread.

Revision Contents
Changeset List

PathSize
native/
profile/
55 lines
web/
settings/
51 lines

Diff 43780

View Options

native/profile/profile-screen.react.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { View, Text } from 'react-native'; import { View, Text } from 'react-native';
import QRCode from 'react-native-qrcode-svg'; import QRCode from 'react-native-qrcode-svg';
import { qrCodeLinkURL } from 'lib/facts/links.js'; import { qrCodeLinkURL } from 'lib/facts/links.js';
import { useSecondaryDeviceLogIn } from 'lib/hooks/login-hooks.js'; import { useSecondaryDeviceLogIn } from 'lib/hooks/login-hooks.js';
import { useQRAuth } from 'lib/hooks/qr-auth.js'; import { useQRAuth } from 'lib/hooks/qr-auth.js';
import { uintArrayToHexString } from 'lib/media/data-utils.js'; import { uintArrayToHexString } from 'lib/media/data-utils.js';
import { useTunnelbroker } from 'lib/tunnelbroker/tunnelbroker-context.js'; import { useTunnelbroker } from 'lib/tunnelbroker/tunnelbroker-context.js';
import type { BackupKeys } from 'lib/types/backup-types.js'; import type { BackupKeys } from 'lib/types/backup-types.js';
import { getContentSigningKey } from 'lib/utils/crypto-utils.js'; import { getContentSigningKey } from 'lib/utils/crypto-utils.js';
import { getMessageForException } from 'lib/utils/errors.js';
import type { QRCodeSignInNavigationProp } from './qr-code-sign-in-navigator.react.js'; import type { QRCodeSignInNavigationProp } from './qr-code-sign-in-navigator.react.js';
import { import {
composeTunnelbrokerQRAuthMessage, composeTunnelbrokerQRAuthMessage,
parseTunnelbrokerQRAuthMessage, parseTunnelbrokerQRAuthMessage,
} from './qr-code-utils.js'; } from './qr-code-utils.js';
import { commCoreModule } from '../native-modules.js'; import { commCoreModule } from '../native-modules.js';
import type { NavigationRoute } from '../navigation/route-names.js'; import type { NavigationRoute } from '../navigation/route-names.js';
import { useStyles } from '../themes/colors.js'; import { useStyles } from '../themes/colors.js';
import * as AES from '../utils/aes-crypto-module.js'; import * as AES from '../utils/aes-crypto-module.js';
import {
appOutOfDateAlertDetails,
unknownErrorAlertDetails,
} from '../utils/alert-messages.js';
import Alert from '../utils/alert.js'; import Alert from '../utils/alert.js';
type QRCodeScreenProps = { type QRCodeScreenProps = {
+navigation: QRCodeSignInNavigationProp<'QRCodeScreen'>, +navigation: QRCodeSignInNavigationProp<'QRCodeScreen'>,
+route: NavigationRoute<'QRCodeScreen'>, +route: NavigationRoute<'QRCodeScreen'>,
}; };
function performBackupRestore(backupKeys: BackupKeys): Promise<void> { function performBackupRestore(backupKeys: BackupKeys): Promise<void> {
Show All 28 Linesfunction QRCodeScreen(props: QRCodeScreenProps): React.Node {
const secondaryDeviceLogIn = useSecondaryDeviceLogIn(); const secondaryDeviceLogIn = useSecondaryDeviceLogIn();
const performRegistration = React.useCallback( const performRegistration = React.useCallback(
async (userID: string) => { async (userID: string) => {
try { try {
await secondaryDeviceLogIn(userID); await secondaryDeviceLogIn(userID);
} catch (err) { } catch (err) {
console.error('Secondary device registration error:', err); console.error('Secondary device registration error:', err);
Alert.alert('Registration failed', 'Failed to upload device keys', [ const messageForException = getMessageForException(err);
{ text: 'OK' }, if (
]); messageForException === 'client_version_unsupported' ||
messageForException === 'Unsupported version'
) {
Alert.alert(
appOutOfDateAlertDetails.title,
appOutOfDateAlertDetails.message,
);
} else {
Alert.alert(
unknownErrorAlertDetails.title,
unknownErrorAlertDetails.message,
);
}
void generateQRCode(); void generateQRCode();
} }
}, },
[secondaryDeviceLogIn, generateQRCode], [secondaryDeviceLogIn, generateQRCode],
); );
React.useEffect(() => { React.useEffect(() => {
void generateQRCode(); void generateQRCode();
▲ Show 20 Lines • Show All 89 Lines • Show Last 20 Lines
View Options

web/settings/account-settings.react.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { View, Text } from 'react-native'; import { View, Text } from 'react-native';
import QRCode from 'react-native-qrcode-svg'; import QRCode from 'react-native-qrcode-svg';
import { qrCodeLinkURL } from 'lib/facts/links.js'; import { qrCodeLinkURL } from 'lib/facts/links.js';
import { useSecondaryDeviceLogIn } from 'lib/hooks/login-hooks.js'; import { useSecondaryDeviceLogIn } from 'lib/hooks/login-hooks.js';
import { useQRAuth } from 'lib/hooks/qr-auth.js'; import { useQRAuth } from 'lib/hooks/qr-auth.js';
import { uintArrayToHexString } from 'lib/media/data-utils.js'; import { uintArrayToHexString } from 'lib/media/data-utils.js';
import { useTunnelbroker } from 'lib/tunnelbroker/tunnelbroker-context.js'; import { useTunnelbroker } from 'lib/tunnelbroker/tunnelbroker-context.js';
import type { BackupKeys } from 'lib/types/backup-types.js'; import type { BackupKeys } from 'lib/types/backup-types.js';
import { getContentSigningKey } from 'lib/utils/crypto-utils.js'; import { getContentSigningKey } from 'lib/utils/crypto-utils.js';
import { getMessageForException } from 'lib/utils/errors.js';
import type { QRCodeSignInNavigationProp } from './qr-code-sign-in-navigator.react.js'; import type { QRCodeSignInNavigationProp } from './qr-code-sign-in-navigator.react.js';
import { import {
composeTunnelbrokerQRAuthMessage, composeTunnelbrokerQRAuthMessage,
parseTunnelbrokerQRAuthMessage, parseTunnelbrokerQRAuthMessage,
} from './qr-code-utils.js'; } from './qr-code-utils.js';
import { commCoreModule } from '../native-modules.js'; import { commCoreModule } from '../native-modules.js';
import type { NavigationRoute } from '../navigation/route-names.js'; import type { NavigationRoute } from '../navigation/route-names.js';
import { useStyles } from '../themes/colors.js'; import { useStyles } from '../themes/colors.js';
import * as AES from '../utils/aes-crypto-module.js'; import * as AES from '../utils/aes-crypto-module.js';
import {
appOutOfDateAlertDetails,
unknownErrorAlertDetails,
} from '../utils/alert-messages.js';
import Alert from '../utils/alert.js'; import Alert from '../utils/alert.js';
type QRCodeScreenProps = { type QRCodeScreenProps = {
+navigation: QRCodeSignInNavigationProp<'QRCodeScreen'>, +navigation: QRCodeSignInNavigationProp<'QRCodeScreen'>,
+route: NavigationRoute<'QRCodeScreen'>, +route: NavigationRoute<'QRCodeScreen'>,
}; };
function performBackupRestore(backupKeys: BackupKeys): Promise<void> { function performBackupRestore(backupKeys: BackupKeys): Promise<void> {
Show All 28 Linesfunction QRCodeScreen(props: QRCodeScreenProps): React.Node {
const secondaryDeviceLogIn = useSecondaryDeviceLogIn(); const secondaryDeviceLogIn = useSecondaryDeviceLogIn();
const performRegistration = React.useCallback( const performRegistration = React.useCallback(
async (userID: string) => { async (userID: string) => {
try { try {
await secondaryDeviceLogIn(userID); await secondaryDeviceLogIn(userID);
} catch (err) { } catch (err) {
console.error('Secondary device registration error:', err); console.error('Secondary device registration error:', err);
Alert.alert('Registration failed', 'Failed to upload device keys', [ const messageForException = getMessageForException(err);
{ text: 'OK' }, if (
]); messageForException === 'client_version_unsupported' ||
messageForException === 'Unsupported version'
) {
Alert.alert(
appOutOfDateAlertDetails.title,
appOutOfDateAlertDetails.message,
);
} else {
Alert.alert(
unknownErrorAlertDetails.title,
unknownErrorAlertDetails.message,
);
}
void generateQRCode(); void generateQRCode();
} }
}, },
[secondaryDeviceLogIn, generateQRCode], [secondaryDeviceLogIn, generateQRCode],
); );
React.useEffect(() => { React.useEffect(() => {
void generateQRCode(); void generateQRCode();
▲ Show 20 Lines • Show All 89 Lines • Show Last 20 Lines