Page MenuHomePhabricator
Differential D13214

[lib] Introduce thread timestamps on the JS side
ClosedPublic
Actions

Authored by tomek on Fri, Aug 30, 9:07 AM.
Tags
None
Referenced Files
F2752765: D13214.diff
Wed, Sep 18, 4:15 PM
F2745969: D13214.diff
Wed, Sep 18, 6:59 AM
Unknown Object (File)
Mon, Sep 16, 1:42 PM
Unknown Object (File)
Mon, Sep 16, 11:42 AM
Unknown Object (File)
Sun, Sep 15, 10:15 AM
Unknown Object (File)
Sun, Sep 15, 2:14 AM
Unknown Object (File)
Sat, Sep 14, 11:53 PM
Unknown Object (File)
Sat, Sep 14, 12:51 PM
View All 33 Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
Commits
rCOMMf72ecb2ea151: [lib] Introduce thread timestamps on the JS side
Summary

Create a new property with the timestamps. All the new thick threads will have it. We don't really need to have a migration introducing them, because all the thick threads we have were created by code on dev environments.

https://linear.app/comm/issue/ENG-8751/add-a-timestamps-property-to-a-thick-thread-info

Depends on D13211

Test Plan

On native and web, create a new thick thread, check if it contains the timestamps. Restart the apps and check if the timestamps are still there.

Diff Detail

Repository
rCOMM Comm
Branch
timestamps
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Fri, Aug 30, 9:07 AM
Herald added a subscriber: ashoat. · View Herald TranscriptFri, Aug 30, 9:07 AM
tomek added a parent revision: D13211: [native][web] Add a timestamp column to threads table.Fri, Aug 30, 9:08 AM
tomek edited the summary of this revision. (Show Details)
tomek updated this revision to Diff 43820.Fri, Aug 30, 9:29 AM

Remove replies count timestamp - the replies count is based on the messages which means it doesn't need a timestamp.

Harbormaster completed remote builds in B31375: Diff 43819.Fri, Aug 30, 9:40 AM
Harbormaster completed remote builds in B31376: Diff 43820.Fri, Aug 30, 9:47 AM
tomek requested review of this revision.Fri, Aug 30, 9:47 AM
tomek added a child revision: D13215: [lib] Check the timestamps when changing thread settings.Fri, Aug 30, 10:17 AM
tomek updated this revision to Diff 43827.Mon, Sep 2, 7:20 AM

Rename

Harbormaster completed remote builds in B31382: Diff 43827.Mon, Sep 2, 7:37 AM
inka accepted this revision.Tue, Sep 3, 3:06 AM
This revision is now accepted and ready to land.Tue, Sep 3, 3:06 AM
inka added inline comments.Tue, Sep 3, 3:13 AM
lib/types/thread-types.js
152 ↗(On Diff #43827)

What is this representing?

tomek added inline comments.Thu, Sep 5, 1:21 AM
lib/types/thread-types.js
152 ↗(On Diff #43827)

It represents the last change of the unread status.

Closed by commit rCOMMf72ecb2ea151: [lib] Introduce thread timestamps on the JS side (authored by tomek). · Explain WhyFri, Sep 6, 8:10 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMf72ecb2ea151: [lib] Introduce thread timestamps on the JS side.

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
9 lines
21 lines
types/
35 lines
utils/
14 lines
1 line

Diff 43820

View Options

lib/shared/dm-ops/create-thread-spec.js

Loading...
View Options

lib/shared/thread-utils.js

Loading...
View Options

lib/types/thread-types.js

Loading...
View Options

lib/utils/thread-ops-utils.js

Loading...
View Options

lib/utils/thread-ops-utils.test.js

Loading...