[lib] Check the timestamps when removing thread members
ClosedPublic
Actions

Authored by tomek on Sep 3 2024, 7:17 AM.

Details

Reviewers

kamil
inka

Commits

rCOMMff656da6fda9: [lib] Check the timestamps when removing thread members

Summary

Check the timestamp and don't remove members when the timestamp is more recent than the operation.

https://linear.app/comm/issue/ENG-9117/update-removemembersspec

Depends on D13220

Test Plan

Perform a couple of remove and add members operations and check if the membership and timestamps are correct.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Sep 3 2024, 7:17 AM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 3 2024, 7:17 AM

Harbormaster completed remote builds in B31411: Diff 43857.Sep 3 2024, 7:48 AM

tomek requested review of this revision.Sep 3 2024, 7:48 AM

tomek added a child revision: D13234: [lib] Check the timestamps when updating thread subscription.Sep 3 2024, 9:58 AM

inka accepted this revision.Sep 5 2024, 12:56 AM

This revision is now accepted and ready to land.Sep 5 2024, 12:56 AM

Closed by commit rCOMMff656da6fda9: [lib] Check the timestamps when removing thread members (authored by tomek). · Explain WhySep 6 2024, 8:10 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMff656da6fda9: [lib] Check the timestamps when removing thread members.

Revision Contents
Changeset List

Path

Size

lib/

shared/

dm-ops/

remove-members-spec.js

27 lines

Diff 43937

View Options

lib/shared/dm-ops/remove-members-spec.js

[lib] Check the timestamps when removing thread membersClosedPublicActions